Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] calendar: invitation for deleted event (recurring) #38295

Closed
wants to merge 1 commit into from

Conversation

@agr-odoo
Copy link
Contributor

commented Oct 9, 2019

From calendar create a recursive event and add some guests. Delete one
event of the chain.

Invitations (Mail) will be created for the deleted event, and should not
be the case because the event has been deleted.

This happens because the recursive event is really just a record in the
database representing all the generated events. When the user want to
delete an event in the chain, a new event, copy of the "parent" event
has to be registered and subsequently disabled.
In the process of creating the event the mail is sent as
side effect. Note that the code to prevent this was partially there
because a context flag "dont_notify" is sent by the unlink in
Calendar.Meeting but was ignored from the mail subsystem.

opw-2039576

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

From calendar create a recursive event and add some guests. Delete one
event of the chain.

Invitations (Mail) will be created for the deleted event, and should not
be the case because the event has been deleted.

This happens because the recursive event is really just a record in the
database representing all the generated events. When the user want to
delete an event in the chain, a new event, copy of the "parent" event
has to be registered and subsequently disabled.
In the process of creating the event the mail is sent as
side effect. Note that the code to prevent this was partially there
because a context flag "dont_notify" is sent by the unlink in
Calendar.Meeting but was ignored from the mail subsystem.

opw-2039576
@agr-odoo agr-odoo force-pushed the odoo-dev:11.0-opw-2039576-fix-agr branch from f7642b4 to 4e0e9da Oct 9, 2019
@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@agr-odoo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2019

@nim-odoo
this is just a backport of b8c7edd
so it should apply just to 11

@C3POdoo C3POdoo added the OE label Oct 9, 2019
@robodoo robodoo added the CI 🤖 label Oct 9, 2019
@nim-odoo nim-odoo requested a review from len-odoo Oct 10, 2019
Copy link
Contributor

left a comment

@fw-bot up to saas-11.3
robodoo r+

@robodoo robodoo added the r+ 👌 label Oct 10, 2019
@fw-bot

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Forward-porting to 'saas-11.3'.

robodoo pushed a commit that referenced this pull request Oct 10, 2019
From calendar create a recursive event and add some guests. Delete one
event of the chain.

Invitations (Mail) will be created for the deleted event, and should not
be the case because the event has been deleted.

This happens because the recursive event is really just a record in the
database representing all the generated events. When the user want to
delete an event in the chain, a new event, copy of the "parent" event
has to be registered and subsequently disabled.
In the process of creating the event the mail is sent as
side effect. Note that the code to prevent this was partially there
because a context flag "dont_notify" is sent by the unlink in
Calendar.Meeting but was ignored from the mail subsystem.

opw-2039576

closes #38295

Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Merged at cf94c65, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.