Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: message compose wizard #38298

Closed
wants to merge 1 commit into from

Conversation

@Feyensv
Copy link
Contributor

commented Oct 9, 2019

if partner_ids and template_id are set, a traceback happens.

Indeed, some mail fields are not taken from the res_ids when partner_ids
is set.

When trying to update the values with the one from the template, the
existing values are popped, which raised an error as those keys weren't
set.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@Feyensv Feyensv requested a review from tde-banana-odoo Oct 9, 2019
@robodoo robodoo added the seen 🙂 label Oct 9, 2019
@C3POdoo C3POdoo added the RD label Oct 9, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

LGTM! Could you just update commit message header according to guidelines (https://www.odoo.com/documentation/12.0/reference/guidelines.html#commit-message-header) ?

@robodoo robodoo added the CI 🤖 label Oct 9, 2019
@Feyensv Feyensv force-pushed the odoo-dev:11.0-fixes-vfe branch from be53221 to 8f22907 Oct 9, 2019
if partner_ids and template_id are set, a traceback happens.

Indeed, some mail fields are not taken from the res_ids when partner_ids
is set.

When trying to update the values with the one from the template, the
existing values are popped, which raised an error as those keys weren't
set.
@robodoo robodoo removed the CI 🤖 label Oct 9, 2019
@Feyensv Feyensv force-pushed the odoo-dev:11.0-fixes-vfe branch from 8f22907 to 16f45ce Oct 9, 2019
@robodoo robodoo added the CI 🤖 label Oct 9, 2019
@Feyensv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

@tde-banana-odoo does it suit your vision of commit guidelines? :D

@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

It is not my vision, it is just following guidelines. Ordering a bit the chaos in developpers mind.

@robodoo r+

@robodoo robodoo added the r+ 👌 label Oct 10, 2019
robodoo pushed a commit that referenced this pull request Oct 10, 2019
if partner_ids and template_id are set, a traceback happens.

Indeed, some mail fields are not taken from the res_ids when partner_ids
is set.

When trying to update the values with the one from the template, the
existing values are popped, which raised an error as those keys weren't
set.

closes #38298

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Merged at c8ad614, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.