Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[IMP] website: add templates for header in default theme #38950
+738
−99
Conversation
| @@ -1122,6 +1122,33 @@ table.table_desc tr td { | |||
| } | |||
| } | |||
|
|
|||
| // Navbar templates | |||
| .o_navbar_showcase{ | |||
This comment has been minimized.
This comment has been minimized.
qsm-odoo
Oct 17, 2019
Contributor
Quick comment before I check deeper: add a space before { and basically follow this: https://github.com/odoo/odoo/wiki/SCSS-coding-guidelines (even though I did not double check those guidelines for a while...
|
@bvr-odoo Did you check the themes still work the same way with all combinations of options ? (in some theme we have an hamburger layout for example). If you did not install themes yet, check with @rdeodoo next to you, he's an expert now :) @sbuhl Maybe you can have a look before me to give your functional opinion on this ? (remembering we will move this to the left panel after). |
|
|
||
| .o_navbar_brand{ | ||
| .container{ | ||
| -webkit-flex-wrap: wrap !important; |
This comment has been minimized.
This comment has been minimized.
qsm-odoo
Oct 17, 2019
Contributor
Don't need vendor prefixes rules, we add them automatically for the browsers we support.
| } | ||
| .navbar-brand{ | ||
| margin-top: 10px; | ||
| margin-bottom: 10px; |
This comment has been minimized.
This comment has been minimized.
qsm-odoo
Oct 17, 2019
Contributor
There is probably a meaningful bootstrap variable (or an expression using those) to use instead of 10px (and even when hardcoding values, most of them should be expressed in rem units instead of px.
| @@ -326,6 +326,28 @@ | |||
| </xpath> | |||
| </template> | |||
|
|
|||
| <!-- Navbar templates --> | |||
| <template id="navbar_showcase" inherit_id="website.layout" name="Navbar Showcase" active="False"> | |||
This comment has been minimized.
This comment has been minimized.
qsm-odoo
Oct 17, 2019
Contributor
Prefix the id by "template_" for your two templates, it will be clearer for the future
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
a2eac51
to
1870da7
This comment has been minimized.
This comment has been minimized.
sbuhl
commented
Oct 17, 2019
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
1870da7
to
bf9144f
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
bf9144f
to
33e9e2b
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
79d4108
to
54095b1
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
54095b1
to
7bbfd80
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
7bbfd80
to
0be00de
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
0be00de
to
4c9bf25
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
4c9bf25
to
969e5e1
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
969e5e1
to
8003a45
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 5, 2019
The name of the site displayed on the website is now dissociated from the general name of the website. Part of odoo#38950 task-2087641
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 5, 2019
This commit adds header templates available in the customize dialog and compatible with all themes. Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 5, 2019
This commit adds footer templates available in the customize dialog and compatible with all themes. Also remove all t-fields from footers to have only static contents in footers. For social links, a controller is added so that a "static url" /website/social/xxx always redirect to the correct set URL for the given xxx social network. Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 5, 2019
Adding a choice of several header behavior in the customize menu (fixed, fade out with scroll, etc.) Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 5, 2019
In case a controller with a relative url return an absolute link the current crawler follow the redirect and all external link of this external url too. Now we don't follow redirection if it is on an other netloc that the current one. Part of odoo#38950 task-2087641
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
5a20f1c
to
31f206b
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 11, 2019
The name of the site displayed on the website is now dissociated from the general name of the website. Part of odoo#38950 task-2087641
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 11, 2019
This commit adds header templates available in the customize dialog and compatible with all themes. Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 11, 2019
This commit adds footer templates available in the customize dialog and compatible with all themes. Also remove all t-fields from footers to have only static contents in footers. For social links, a controller is added so that a "static url" /website/social/xxx always redirect to the correct set URL for the given xxx social network. Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 11, 2019
Adding a choice of several header behavior in the customize menu (fixed, fade out with scroll, etc.) Part of odoo#38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 11, 2019
In case a controller with a relative url return an absolute link the current crawler follow the redirect and all external link of this external url too. Now we don't follow redirection if it is on an other netloc that the current one. Part of odoo#38950 task-2087641
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
31f206b
to
ce284fc
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
ce284fc
to
b40789c
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
b40789c
to
a4c88dd
This commit adds footer templates available in the customize dialog and compatible with all themes. Also remove all t-fields from footers to have only static contents in footers. For social links, a controller is added so that a "static url" /website/social/xxx always redirect to the correct set URL for the given xxx social network. Part of #38950 task-2087641 Co-authored-by: qsm-odoo <qsm@odoo.com>
task-2087641
task-2087641
adjusting the padding-top of the main element when switching between desktop and mobile view. Desactivate animation/transition when refreshing the page with a scrollTop > 0. task-2087641
bvr-odoo
force-pushed the
odoo-dev:master-templates-for-header-bvr
branch
from
a4c88dd
to
f96cc41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bvr-odoo commentedOct 17, 2019
•
edited by qsm-odoo
task-2087641