Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website: add templates for header in default theme #38950

Open
wants to merge 8 commits into
base: master
from

Conversation

@bvr-odoo
Copy link
Contributor

bvr-odoo commented Oct 17, 2019

task-2087641

@robodoo robodoo added the seen 🙂 label Oct 17, 2019
@@ -1122,6 +1122,33 @@ table.table_desc tr td {
}
}

// Navbar templates
.o_navbar_showcase{

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Oct 17, 2019

Contributor

Quick comment before I check deeper: add a space before { and basically follow this: https://github.com/odoo/odoo/wiki/SCSS-coding-guidelines (even though I did not double check those guidelines for a while...

Copy link
Contributor

qsm-odoo left a comment

@bvr-odoo Did you check the themes still work the same way with all combinations of options ? (in some theme we have an hamburger layout for example). If you did not install themes yet, check with @rdeodoo next to you, he's an expert now :)

@sbuhl Maybe you can have a look before me to give your functional opinion on this ? (remembering we will move this to the left panel after).


.o_navbar_brand{
.container{
-webkit-flex-wrap: wrap !important;

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Oct 17, 2019

Contributor

Don't need vendor prefixes rules, we add them automatically for the browsers we support.

}
.navbar-brand{
margin-top: 10px;
margin-bottom: 10px;

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Oct 17, 2019

Contributor

There is probably a meaningful bootstrap variable (or an expression using those) to use instead of 10px (and even when hardcoding values, most of them should be expressed in rem units instead of px.

@@ -326,6 +326,28 @@
</xpath>
</template>

<!-- Navbar templates -->
<template id="navbar_showcase" inherit_id="website.layout" name="Navbar Showcase" active="False">

This comment has been minimized.

Copy link
@qsm-odoo

qsm-odoo Oct 17, 2019

Contributor

Prefix the id by "template_" for your two templates, it will be clearer for the future

@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from a2eac51 to 1870da7 Oct 17, 2019
@C3POdoo C3POdoo added the RD label Oct 17, 2019
@robodoo robodoo added the CI 🤖 label Oct 17, 2019
@sbuhl

This comment has been minimized.

Copy link

sbuhl commented Oct 17, 2019

Hello @bvr-odoo and @qsm-odoo
Functionally, it looks good and it works :-)
Benjamin, if you have any other idea. Do not hesitate.

@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 1870da7 to bf9144f Oct 18, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 18, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from bf9144f to 33e9e2b Oct 28, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 28, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 79d4108 to 54095b1 Oct 28, 2019
@robodoo robodoo added the CI 🤖 label Oct 28, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 54095b1 to 7bbfd80 Oct 29, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 29, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 7bbfd80 to 0be00de Oct 31, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 31, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 0be00de to 4c9bf25 Oct 31, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 31, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 4c9bf25 to 969e5e1 Nov 4, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 4, 2019
@KangOl KangOl force-pushed the odoo:master branch from 86c80d3 to ab6d0c3 Nov 6, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 969e5e1 to 8003a45 Nov 6, 2019
@robodoo robodoo added the CI 🤖 label Dec 4, 2019
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
The name of the site displayed on the website is now dissociated from
the general name of the website.

Part of odoo#38950
task-2087641
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
This commit adds header templates available in the customize dialog and
compatible with all themes.

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
This commit adds footer templates available in the customize dialog and
compatible with all themes.

Also remove all t-fields from footers to have only static contents in
footers. For social links, a controller is added so that a "static url"
/website/social/xxx always redirect to the correct set URL for the given
xxx social network.

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
Adding a choice of several header behavior in the customize menu (fixed,
fade out with scroll, etc.)

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
In case a controller with a relative url return an absolute link
the current crawler follow the redirect and all external link of this
external url too.

Now we don't follow redirection if it is on an other netloc that the
current one.

Part of odoo#38950
task-2087641
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 7d17359 to 5a20f1c Dec 5, 2019
@robodoo robodoo removed the CI 🤖 label Dec 5, 2019
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
The name of the site displayed on the website is now dissociated from
the general name of the website.

Part of odoo#38950
task-2087641
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
This commit adds header templates available in the customize dialog and
compatible with all themes.

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
This commit adds footer templates available in the customize dialog and
compatible with all themes.

Also remove all t-fields from footers to have only static contents in
footers. For social links, a controller is added so that a "static url"
/website/social/xxx always redirect to the correct set URL for the given
xxx social network.

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
Adding a choice of several header behavior in the customize menu (fixed,
fade out with scroll, etc.)

Part of odoo#38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
bvr-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 5, 2019
In case a controller with a relative url return an absolute link
the current crawler follow the redirect and all external link of this
external url too.

Now we don't follow redirection if it is on an other netloc that the
current one.

Part of odoo#38950
task-2087641
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 5a20f1c to 31f206b Dec 5, 2019
@robodoo robodoo added the CI 🤖 label Dec 5, 2019
bvr-odoo and others added 6 commits Oct 17, 2019
This commit adds header templates available in the customize dialog and
compatible with all themes.

Part of #38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
The name of the site displayed on the website is now dissociated from
the general name of the website.

Part of #38950
task-2087641
This commit adds footer templates available in the customize dialog and
compatible with all themes.

Also remove all t-fields from footers to have only static contents in
footers. For social links, a controller is added so that a "static url"
/website/social/xxx always redirect to the correct set URL for the given
xxx social network.

Part of #38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
Adding a choice of several header behavior in the customize menu (fixed,
fade out with scroll, etc.)

Part of #38950
task-2087641

Co-authored-by: qsm-odoo <qsm@odoo.com>
In case a controller with a relative url return an absolute link
the current crawler follow the redirect and all external link of this
external url too.

Now we don't follow redirection if it is on an other netloc that the
current one.

Part of #38950
task-2087641
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from 31f206b to ce284fc Dec 11, 2019
@robodoo robodoo removed the CI 🤖 label Dec 11, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from ce284fc to b40789c Dec 11, 2019
@robodoo robodoo added the CI 🤖 label Dec 11, 2019
@bvr-odoo bvr-odoo force-pushed the odoo-dev:master-templates-for-header-bvr branch from b40789c to a4c88dd Dec 12, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.