Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the whole editor left panel UI #38959

Open
wants to merge 21 commits into
base: master
from

Conversation

@qsm-odoo
Copy link
Contributor

qsm-odoo commented Oct 17, 2019

No description provided.

@qsm-odoo qsm-odoo self-assigned this Oct 17, 2019
@robodoo robodoo added the seen 🙂 label Oct 17, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch 3 times, most recently from 919c65d to 7c7051e Oct 17, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch 6 times, most recently from 7f2e3bd to aab64df Oct 21, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch 5 times, most recently from eccf1f4 to d697c58 Oct 28, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch 4 times, most recently from 997d7d0 to cd6d3e1 Nov 5, 2019
@KangOl KangOl force-pushed the odoo:master branch from 86c80d3 to ab6d0c3 Nov 6, 2019
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch 4 times, most recently from 4f399ad to ee8f653 Nov 6, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 8, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 13, 2019
This will allow to do the following:

1) Show a preview overlay over an element
2) Block preview overlays -> the overlay at step 1 stays no matter what
3) Encourage the user to do something that edits what the preview
   overlay is currently showing.
4) The edition is finished, go back to normal by unblocking preview
   overlays.

Part of odoo#38959
task-2066614
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 13, 2019
Previously, background size and position for snippets was configured in
a modal, the user could choose a "focus point", which is rather
unintuitive. They could also choose to use the "contain" background
mode, with or without repeat, or a third option, where they could
customize everything, from the background size in both directions to
whether to repeat the background in only one or in both directions.

This commit streamlines the background-sizing options, only the "cover"
and "repeat pattern" options have been kept, as they cover almost every
use case. Their configuration has been moved into the options menu for
consistency with the rest of the editor, and the background's position
is now chosen by clicking on the corresponding menu option, and dragging
the background to the desired place.

Part of odoo#38959
maintask-2066614
task-2088304
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 13, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 13, 2019
Now, we should either use:
- A we-select (in the end, same as collapse except it does not push the
  elements in the UI)
- A simple div to always display the elements

Part of odoo#38959
task-2066614
@robodoo robodoo added the CI 🤖 label Nov 13, 2019
qsm-odoo and others added 21 commits Nov 13, 2019
closes #40184

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Changing the filter color and its intensity was not working anymore
because of failed JS refactoring when the logic was shared for both
blog posts and events in website.
This commit adds buttons to move sections up or down and to move columns
left or right, which is more user-friendly than drag-and-drop in some
cases.

Part of #38959
maintask-2066614
task-2088265
* web_editor, website_blog, mass_mailing

In preparation of the new left panel UI, remove all snippet options UI
icons as we do not want them anymore to simplify the UI.

Part of #38959
task-2066614
Not relevant anymore in the new editor UI.

Part of #38959
task-2066614
* website, website_blog, website_form, website_sale

+ introduce default UI for snippet options
+ refactor style of icon buttons

Part of #38959
task-2066614
* web_editor

Previously, the user could choose their anchor names using a modal
window, anchor names also have weird rules, this was not a great user
experience.

This commit makes the anchor button generate anchors automatically based
on the first title in a section, or the snippet name if there are none.
If the anchor name is already taken, it is suffixed by a number. After
it has been generated, it is also copied to the clipboard and the user
is shown a toast to tell them the anchor has been generated and copied.
The anchor is displayed in the toast along with an edit button that will
open the same edition modal as previously, but it is now less
restrictive.

Part of #38959
maintask-2066614
task-2088270
Currently we have:
- a colorpicker for background color of snippets
- a colorpicker for foreground and background text (topbar)
- a colorpicker for menu/footer/navbar/etc
These 3 are separate colorpickers with different options.

After this Commit
All 3 will use the same color palette wich allow you to select
theme color, common colors, custom color and transparent filter.

Part of #38959
maintask-2066614
task-2087383
* website

Now snippet options can be defined as a button which can be placed next
to the clone and delete buttons, through a new "isTopOption" method.

This commit also review the buttons and title design and take advantage
of the feature to review the way snippets options are added in their
container (that code indeed contained useless part since 13.0).

Part of #38959
task-2066614
-> move the move buttons next to the drag button

Part of #38959
task-2066614
* web_editor, website_sale

Part of #38959
task-2066614
*: website, mass_mailing

Part of #38959
maintask-2066614
task-2087383

Co-authored-by: fja-odoo <fja@odoo.com>
* web_editor

This commit adds a slide counter in carousel snippets option menu, as
well as left and right buttons, this way the user can manage their
slides entirely from the options, instead of having to go to the block
itself to navigate to where they want before going back to the option
menu to add or remove a slide.

Part of #38959
maintask-2066614
task-2088291

Co-authored-by: Samuel Degueldre <sad@odoo.com>
Previously, background size and position for snippets was configured in
a modal, the user could choose a "focus point", which is rather
unintuitive. They could also choose to use the "contain" background
mode, with or without repeat, or a third option, where they could
customize everything, from the background size in both directions to
whether to repeat the background in only one or in both directions.

This commit streamlines the background-sizing options, only the "cover"
and "repeat pattern" options have been kept, as they cover almost every
use case. Their configuration has been moved into the options menu for
consistency with the rest of the editor, and the background's position
is now chosen by clicking on the corresponding menu option, and dragging
the background to the desired place.

Part of #38959
maintask-2066614
task-2088304
This will allow to do the following:

1) Show a preview overlay over an element
2) Block preview overlays -> the overlay at step 1 stays no matter what
3) Encourage the user to do something that edits what the preview
   overlay is currently showing.
4) The edition is finished, go back to normal by unblocking preview
   overlays.

Part of #38959
task-2066614
Now, we should either use:
- A we-select (in the end, same as collapse except it does not push the
  elements in the UI)
- A simple div to always display the elements

Part of #38959
task-2066614
@qsm-odoo qsm-odoo force-pushed the odoo-dev:master-left-panel-v2-qsm branch from 9074be2 to 72bd37d Nov 13, 2019
@robodoo robodoo removed the CI 🤖 label Nov 13, 2019
qsm-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 13, 2019
Now, the editor UI can suggest options the same way as select-class but
for editing a data attribute.

Part of odoo#38959
task-2066614
@robodoo robodoo added the CI 🤖 label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.