Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_slides: Do not refresh after adding slides/sections #39242

Open
wants to merge 4 commits into
base: master
from

Conversation

@qmo-odoo
Copy link
Contributor

qmo-odoo commented Oct 23, 2019

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Oct 23, 2019
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 8113834 to 954e967 Oct 23, 2019
@C3POdoo C3POdoo added the RD label Oct 23, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 23, 2019
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 0b522a7 to 0d3817a Oct 23, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 23, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage, quiz and certifications).

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 0d3817a to a68c348 Oct 23, 2019
@robodoo robodoo added the CI 🤖 label Oct 23, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 23, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from a68c348 to 4edc234 Oct 23, 2019
@robodoo robodoo removed the CI 🤖 label Oct 23, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 23, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 4edc234 to 2bcd715 Oct 23, 2019
@robodoo robodoo added the CI 🤖 label Oct 23, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 24, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 2bcd715 to 7a453d4 Oct 24, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 24, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 24, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 7a453d4 to c847480 Oct 24, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 24, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 25, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 1f0b0e2 to d862695 Oct 25, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 25, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 29, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 30, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Oct 30, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 304890e to e6679be Oct 30, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Oct 30, 2019
@KangOl KangOl force-pushed the odoo:master branch from 86c80d3 to ab6d0c3 Nov 6, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Nov 22, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from e6679be to 4273425 Nov 22, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 22, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 12, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 4273425 to 3f6837b Dec 12, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 12, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 19, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from 3f6837b to ba8bff2 Dec 19, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 19, 2019
qmo-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 30, 2019
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: odoo#39242
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from ba8bff2 to fe33f92 Dec 30, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 30, 2019
qmo-odoo added 4 commits Oct 23, 2019
To ignore as it will be applied in an other batch of fixes for 13.0
This commit allows the user to add slides and sections in the front-end
without having to refresh the page. The slide, the section or both at a time
will directly be added to the dom after the rpc call.

This change allows us to completely remove the resequencing logic
in the add_slide controller and the slide.channel model.

Note that a few particular type of slides will still need a redirection
to the backend (webpage and quiz).

Also, some _rpc calls had to be replaced by ajax.jsonRpc due to the
_rpc calls not working at all for the newly added slide/section controls.

LINKS:

TaskID: 2089854
PR: #39242
Add a more in-depth publisher tour that will test more functionalities
and also check that the new no-refresh policy does not break anything in terms
of widget binding.
@qmo-odoo qmo-odoo force-pushed the odoo-dev:master-elearning-no-refresh-qmo branch from fe33f92 to 481cd36 Jan 14, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.