[FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #39370

jev-odoo · 2019-10-25T09:45:38Z

Before this commit, trying to put a transaction in a state
where it was already in was causing an error.

For example: Putting a transaction in'Done' when it was
already in'Done' caused an error
'Only draft/authorized transaction can be posted.'

Now, we just log a note that the transaction is
already in the required state and pass over.

dbo-odoo · 2019-10-28T13:21:52Z

addons/payment/models/payment_acquirer.py

+                return False
+            return True
+
+        tx_to_process = self.filtered(filter_trans)


I really dislike that your filtering method logs stuff... for me, it should only handle the recordset and the logging should be done in the flow

tx_to_process = self.filtered(lambda tx: tx.state == 'draft') tx_already_pending = self.filtered(lambda tx: tx.state == 'pending') tx_bad_state = self - tx_to_process - tx_already_pending for pending_tx in tx_already_pending: _logger.info('blablabla') for bad_tx in tx_bad_state: _logger.warning('machinmachinmachin') # then go one with the tx_to_process recordset

same comment applies for all methods that use this

dbo-odoo · 2019-10-28T13:21:52Z

addons/payment/models/payment_acquirer.py

+            'date': datetime.now().strftime(DEFAULT_SERVER_DATETIME_FORMAT),
+            'state_message': '',
+        })
+        tx_to_process._log_payment_transaction_received()


just checked to be sure: this is indeed a multi method (note to self)

dbo-odoo · 2019-12-02T16:36:15Z

@jev-odoo i've hijacked this PR for a fix in payment_stripe_sca since I needed it to work properly. Will merge soon

dbo-odoo · 2019-12-02T16:39:32Z

note to self: cfr https://stripe.com/docs/error-codes

the smart thing would be to raise_for_status if error code is not present

Edit: I have now done the smart thing


        [FIX] payment: No error logged if no real error in transaction

Before this commit, trying to put a transaction in a state where it was already in was causing an error. For example: Putting a transaction in'Done' when it was already in'Done' caused an error 'Only draft/authorized transaction can be posted.' Now, we just log a note that the transaction is already in the good state and pass over.


        [FIX] payment_stripe_sca: better error handling

In some cases, Stripe will return the result of a transaction with a faulty HTTP Status (e.g. 4XX statuses) - not because the request was malformed, but because the payment failed. It is a bit unfortunate that Stripe would not differentiate between payment status and request validity, but that's the state of things. This commit ensures that such a response will be logged correctly, by making the call to `raise_for_status` conditionnal on the response object's status code and internal structure, forwarding the response's json to the validation flow if the status is in the 4XX range and a `code` key is found in the response, as described in https://stripe.com/docs/error-codes While testing this fix, it became apparent that some error message processing in the frontend was not correctly handled as well - instead of purely rejecting the promise, a failed payment should still send its payload to the backend, to allow the server to put the transaction in the correct state according to the response.

dbo-odoo · 2019-12-03T08:22:34Z

@jev-odoo I would appreciate your opinion when you come back on wednesday :)
i'll wait for you before merging

jev-odoo · 2019-12-04T07:14:19Z

@dbo-odoo
Seems good to me.
Sorry to not have done this earlier, I had a serious lack of time ...

Thanks for this ;)

dbo-odoo · 2019-12-04T12:09:06Z

@robodoo r+

robodoo · 2019-12-04T12:51:31Z

Because this PR has multiple commits, I need to know how to merge it:

merge to merge directly, using the PR as merge commit message
rebase-merge to rebase and merge, using the PR as merge commit message
rebase-ff to rebase and fast-forward

dbo-odoo · 2019-12-04T13:01:37Z

@robodoo rebase-ff

robodoo · 2019-12-04T13:01:59Z

Merge method set to rebase and fast-forward


        [FIX] payment_stripe_sca: better error handling

In some cases, Stripe will return the result of a transaction with a faulty HTTP Status (e.g. 4XX statuses) - not because the request was malformed, but because the payment failed. It is a bit unfortunate that Stripe would not differentiate between payment status and request validity, but that's the state of things. This commit ensures that such a response will be logged correctly, by making the call to `raise_for_status` conditionnal on the response object's status code and internal structure, forwarding the response's json to the validation flow if the status is in the 4XX range and a `code` key is found in the response, as described in https://stripe.com/docs/error-codes While testing this fix, it became apparent that some error message processing in the frontend was not correctly handled as well - instead of purely rejecting the promise, a failed payment should still send its payload to the backend, to allow the server to put the transaction in the correct state according to the response. closes #39370 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

robodoo · 2019-12-04T13:38:25Z

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/718657)

dbo-odoo · 2019-12-04T14:43:16Z

@robodoo retry

robodoo · 2019-12-04T15:01:04Z

Staging failed: ci/runbot on 01a5f0d9627d970bda7218cbadb8a73148e194df (view more at http://runbot.odoo.com/runbot/build/719196)

dbo-odoo · 2019-12-04T22:10:41Z

@robodoo retry


        [FIX] payment_stripe_sca: better error handling

In some cases, Stripe will return the result of a transaction with a faulty HTTP Status (e.g. 4XX statuses) - not because the request was malformed, but because the payment failed. It is a bit unfortunate that Stripe would not differentiate between payment status and request validity, but that's the state of things. This commit ensures that such a response will be logged correctly, by making the call to `raise_for_status` conditionnal on the response object's status code and internal structure, forwarding the response's json to the validation flow if the status is in the 4XX range and a `code` key is found in the response, as described in https://stripe.com/docs/error-codes While testing this fix, it became apparent that some error message processing in the frontend was not correctly handled as well - instead of purely rejecting the promise, a failed payment should still send its payload to the backend, to allow the server to put the transaction in the correct state according to the response. closes #39370 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

fw-bot · 2019-12-08T05:53:15Z

This pull request has forward-port PRs awaiting action (not merged or closed): #41375

fw-bot · 2019-12-09T05:53:11Z

This pull request has forward-port PRs awaiting action (not merged or closed): #41389

fw-bot · 2019-12-10T05:53:32Z

This pull request has forward-port PRs awaiting action (not merged or closed): #41389

fw-bot · 2019-12-11T05:54:21Z

This pull request has forward-port PRs awaiting action (not merged or closed): #41389

jev-odoo requested a review from dbo-odoo Oct 25, 2019

robodoo added the seen 🙂 label Oct 25, 2019

C3POdoo added the RD label Oct 25, 2019

robodoo added the CI 🤖 label Oct 25, 2019

dbo-odoo mentioned this pull request Oct 28, 2019

[FIX] payment_paypal: Less confusing transaction logs #39364

Open

dbo-odoo reviewed Oct 28, 2019

View changes

dbo-odoo force-pushed the odoo-dev:12.0-better_payment_error_handling-jev branch from f43b4a6 to f3087c0 Dec 2, 2019

robodoo removed the CI 🤖 label Dec 2, 2019

dbo-odoo force-pushed the odoo-dev:12.0-better_payment_error_handling-jev branch from f3087c0 to 3c976db Dec 2, 2019

jev-odoo and others added 2 commits Oct 25, 2019

dbo-odoo force-pushed the odoo-dev:12.0-better_payment_error_handling-jev branch from 3c976db to 64551ac Dec 2, 2019

robodoo added the CI 🤖 label Dec 2, 2019

dbo-odoo changed the title ~~[FIX] payment: No error logged if no real error in transaction~~ [FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise Dec 3, 2019

robodoo added the r+ 👌 label Dec 4, 2019

robodoo added merging 👷 error 🙅 and removed CI 🤖 merging 👷 r+ 👌 labels Dec 4, 2019

robodoo added CI 🤖 r+ 👌 merging 👷 error 🙅 and removed error 🙅 CI 🤖 merging 👷 r+ 👌 labels Dec 4, 2019

robodoo added CI 🤖 r+ 👌 merging 👷 and removed error 🙅 labels Dec 4, 2019

fw-bot mentioned this pull request Dec 4, 2019

[FW][FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #41375

Closed

robodoo added merged 🎉 and removed merging 👷 labels Dec 4, 2019

robodoo closed this Dec 4, 2019

robodoo deployed to merge Dec 4, 2019 Active

This was referenced Dec 4, 2019

[FW][FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #41377

Closed

[FW][FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #41389

Closed

fw-bot mentioned this pull request Dec 11, 2019

[FW][FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #41701

Open

odoo/odoo

[FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #39370

[FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #39370

jev-odoo commented Oct 25, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dbo-odoo commented Dec 2, 2019 •

edited

This comment has been minimized.

dbo-odoo commented Dec 2, 2019 •

edited

This comment has been minimized.

dbo-odoo commented Dec 3, 2019

This comment has been minimized.

jev-odoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

fw-bot commented Dec 8, 2019

This comment has been minimized.

fw-bot commented Dec 9, 2019

This comment has been minimized.

fw-bot commented Dec 10, 2019

This comment has been minimized.

fw-bot commented Dec 11, 2019

odoo/odoo

Join GitHub today

[FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #39370

[FIX] payment: error logs + [FIX] payment_stripe_sca: less aggressive raise #39370

Conversation

jev-odoo commented Oct 25, 2019

This comment has been minimized.

dbo-odoo Oct 28, 2019

This comment has been minimized.

dbo-odoo Oct 28, 2019

This comment has been minimized.

dbo-odoo Oct 28, 2019

This comment has been minimized.

dbo-odoo commented Dec 2, 2019 • edited

This comment has been minimized.

dbo-odoo commented Dec 2, 2019 • edited

This comment has been minimized.

dbo-odoo commented Dec 3, 2019

This comment has been minimized.

jev-odoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

robodoo commented Dec 4, 2019

This comment has been minimized.

dbo-odoo commented Dec 4, 2019

This comment has been minimized.

fw-bot commented Dec 8, 2019

This comment has been minimized.

fw-bot commented Dec 9, 2019

This comment has been minimized.

fw-bot commented Dec 10, 2019

This comment has been minimized.

fw-bot commented Dec 11, 2019

dbo-odoo commented Dec 2, 2019 •

edited

dbo-odoo commented Dec 2, 2019 •

edited