Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account reporting, xml file in mexican location #39683

wants to merge 6,758 commits into
base: 12.0


Copy link

naomivela commented Oct 31, 2019

Description of the issue/feature this PR addresses:
I been using account module with mexican location, I configured the all the process that I need but when I try to export the xml file in my reports the information included there is wrong.
I change the name of some accounts included in the chart of accounts but even with any modifications the information inside in xml file is wrong and don't change any información, If i create a new account I can't see in my file, I been doing a lot of configurations but the information I see in xml is always the same.
Current behavior before PR:
The behavior is the same, the información I see in the chart of accounts even with any configuration do not match with the information inside of xml file.
Desired behavior after PR is merged:
I need that the information inside the view will be the same in xml file.
Analysis Specification xml COA Odoo 1.pdf

I confirm I have signed the CLA and read the PR guidelines at

Xavier-Do and others added 30 commits Aug 27, 2019
closes #36141

Signed-off-by: Xavier Dollé (xdo) <>
#34737 didn't go in enough depth to
ensure sections and notes don't break purchase flows.

closes #38232

Signed-off-by: Damien Bouvy (dbo) <>
after paypal onboarding, merchant email and pdt token
is not required at all, for the new users.
They can accept payment with just email address.

closes #38756

Signed-off-by: Damien Bouvy (dbo) <>
The goal is to improve the project's overview:

    1/ Switch tooltips
    2/ Increase tags size

closes #38804

Taskid: 2086664
Signed-off-by: Yannick Tivisse (yti) <>
When a BoM is using a component with a quantity required set to 0,
tracebacks were occuring when computing the available quantities
for the kit.

Fixes #38807

closes #38890

Signed-off-by: Simon Lejeune (sle) <>
closes #39020

Signed-off-by: Martin Trigaux (mat) <>
Since commit dba4783, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.

This prevents to display some questions of a survey, as we are
still expecting a structure page/questions. To solve it, we first
append questions with no sections, then all other questions.

closes #39064

Signed-off-by: Richard Mathot (rim) <>
Since commit dba4783, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.

This prevents to display the analysis results of a survey, as we are
still expecting a structure page/questions. To solve it, if a question
does not have a section associated, we use an empty page instead.

closes #39082

X-original-commit: 45c2964
Signed-off-by: Alex Tuyls <>
Fine tuning of c351f00

In the POS module there is the possibility to print receipts.

Before this commit:

    - The currency symbol appears in the receipts but not in sublines
      and discount

After this commit:

    - The currency symbol appears in the receipts but not in sublines


closes #39089

Signed-off-by: Nicolas Martinelli (nim) <>
after this commit :
added a separator at the end of the inherited view

task - 2082289

closes #38254

Signed-off-by: Laurent Smet <>
…le account

With Anglo-Saxon accounting, invoices with stock_moves on a product
having 'real_time' valuation cannot be validated: there is a user error
when the interim account is not reconcilable.

We modify _anglo_saxon_reconcile_valuation so that we do not try to reconcile
when the account is not reconcilable.


closes #38974

Signed-off-by: oco-odoo <>
Install l10n_it_edi, try to import an italian e-invoice (xml). Odoo will create
2 invoices, one draft with the attachment but empty, and another one
with the parsed content of the file.

This happen because the module responsible for the import systematically
create a new invoice instead of reusing the open one.


closes #39095

Signed-off-by: Nicolas Martinelli (nim) <>
Go on a kanban view with a scroll bar
scroll all the way down
Open a record in form view

Use the breadcrumb to go back to the kanban

Before this commit, the kanban was re-opened
but the position were we were before opening the record was lost

This was due to 40dd121
which refactors the dom, puting the action manager on top of controllers

After this commit, when re-opening the kanban, we end up at the same position
we left it at

OPW 2074077

closes #39111

X-original-commit: c0d4887
Signed-off-by: Lucas Perais (lpe) <>
Do not return a boolean but skip bad translations
Introduced at 19e50ea

Fixes #39001
At least fix the error that is thrown, however, this does not solve
the initial error of trying to export the terms of a record that is no
longer present in the database.
As this issue is no longer reproducable, just log a warning as it was

closes #39021

Signed-off-by: Martin Trigaux (mat) <>
Before, en_US was almost always the default in case of 'no language'.
Now, that should be superseded by lang=None;
yet still, en_US plays the role of source language.

In a multilanguage database where en_US was not installed,
writing a translation with lang=None would crash.
This could prevent module installation.

A test is added to cover that case.

In the case where we write a record with lang=None, the source is the
same as the record; in that case the cache contains the value for the under the context keys en_US and None, so we need to
invalidate the cache to avoid getting back the old value.

co-authored with mart-e

opw 2088487
opw 2083710

closes #39040

Signed-off-by: Martin Trigaux (mat) <>

Time to load systray messaging menu is too slow.

Time to load systray messaging menu:
- With 300 direct message channels, it takes at least 1.2 seconds.
- With 300 direct message channels and a dozen of "big" multi-user
  channels (#All, #News, #R&D, etc.), it takes at least 2 seconds.

The RPC 'channel_fetch_preview' is very slow. After some investigating,
it looks like 80% of the time takes place during message_format
postprocess when updating messages based on notifications:


Now, we avoid to make query for each message.
And for attachment's message, we check attachment access rules and
search object only if the message has an attachment.

closes #39063

Signed-off-by: Thibault Delavallee (tde) <>
closes #38361

Signed-off-by: Victor Feyens (vfe) <>
Those tests were raising an assert error if the DB has other websites than the
data/demo ones.

As we have a new module in Odoo 13.0 (odoo/design-themes#178)
which is creating 25 websites, and since the design-themes runbot is now
running tests, we were having a red design-themes runbot.

closes #39140

Signed-off-by: Jérémy Kersten (jke) <>
…hat channels

closes #39151

Signed-off-by: Fabien Pinckaers <>
The XML file homepage view record is not supposed to be deleted as it is used
to bootstrap newly created website.

If that view is deleted, everything's fine. But if that view's page is not
found (m2o link broken somehow), then the code would crash.

This would only appear if the user is playing in the backend in technical but
it seems to happen more than it should.

This commit will prevent the code to crash in such a case.

Step to reproduce:
1. Go to settings > technical > views (debug)
2. Find the xml homepage view (with xml_id)
3. Go to its and break the m2o view_id
4. Try to create a new website, it will crash


closes #39148

X-original-commit: 1d4dd20
Signed-off-by: Romain Derie (rde) <>
In deliveries slips, you can directly create a new serial number.
If you have multiples companies, a field "company" appears.
But if you have only one company, it doesn't appears and there is
no default value for it.

As the field is required, it returns an error "Company field required".

Before this commit:

    - The company_id field in stock_production_lot model does not
      have a default value.

After this commit:

    - The company_id field has a default value which is the user
      current company id.


closes #39125

Signed-off-by: pimodoo <>
The default `compute_sudo=True` makes sense for recomputing stored
fields that are indirectly related to a business operation.  This
ensures that the recomputation of the field does not break an operation
that is not aware of the fields to recompute.

However, computing non-stored fields in superuser mode is usually not
necessary.  It even leads to unexpected values: counting a partner's
sales orders does not give the same result in superuser mode as in
normal mode.  That is why non-stored fields are not computed in
superuser mode by default.

[FIX] account, delivery, event, hr_recruitment, point_of_sale, stock:
adapt the model definition to make all fields with the same compute
method have the same value for `compute_sudo`.

[FIX] sale: split the computation of `invoice_ids`, `invoice_count`
(non-stored) and `invoice_status` (stored), as no code is actually

closes #38805

Signed-off-by: Olivier Dony (odo) <>
Since saas-12.3, deferred actions use native promises. This has the
annoying side-effect of force-deferring promises even if they are
resolved at once... and we relied on the opposite behavior for some
call made in _setActive or option methods.

In master, we should review the async logic of snippet options. Right
now we will rely on the fact those promises are resolved at once but
that we need to avoid for their "async part" anyway. The _setActive
method and the option methods are thus still working synchronously in
stable, despite the new force-deferring promises.

Also, with old promises, when we waited for the resolution of multiple
deferred, the resolve handler received the multiple results as
individual arguments. Now it receives all the results in an array as
a single argument. The resolution of action demands had to be adapted.

closes #39134

X-original-commit: fd157b9
Signed-off-by: Quentin Smetz (qsm) <>
…d values

This fixes a regression introduced by 291a0e9.

closes #39159

Signed-off-by: Raphael Collet (rco) <>
Due to commit f4031c6
it was not more possible to scroll in a grouped kanban.

Steps to reproduce:
* Go to project app
* Select a project with a few numbers of task
* Create as need new task to have more task than visible on the screen
* Try to scroll (BUG)

Note: we also fix the swipe in empty column


closes #39166

X-original-commit: 023941e
Signed-off-by: Adrien Dieudonné (adr) <>
Start odoo-bin using a tier module (like `python3 -m pdb odoo-bin`), the
odoo/addons __path__ contains the relative link to the modules instead
of the absolute link like when directly started (`python3 odoo-bin`).

This cause trouble importing modules because it reuses the relative path
from within other directories.

closes #39164

Signed-off-by: Xavier Dollé (xdo) <>
The basic ORM methods should not silently discard unknown fields, as
they may be a sign of broken code.
closes #37094

Signed-off-by: Olivier Dony (odo) <>
@robodoo robodoo added the CI 🤖 label Nov 12, 2019
fw-bot and others added 2 commits Nov 12, 2019
When using the flamegraph module from a parent directory of odoo, the
dirname method returns a relative path, leading to a traceback.

With this commit, the odoo_path is enforced to be an absolute path.

closes #40124

Signed-off-by: Christophe Monniez (moc) <>
Commit 5fcf891 introduced optimizations for
name_search in several models.  However, that produces some counter-intuitive

In a DB with project and custom data:

    >>> Project = self.env['project.task']
    >>>[('user_id', 'ilike', 'demo')]).mapped('')
    ['Marc Demo']

    >>>[('user_id', 'not ilike', 'demo')]).mapped('')
    ['Marc Demo']

The projects returned with 'not ilike' are a super-set of those returned with

    >>>[('user_id', 'ilike', 'demo')])
    project.task(22, 21, 20, 16, 14, 13)

    >>>[('user_id', 'not ilike', 'demo')])
    project.task(22, 21, 29, 28, 27, 26, 25, 20, 16, 14, 13, 31, 30)

This commit fix this behaviour by choosing '!=' instead of '=' whenever the
operator is a negation operator.

The 'res.users' is more exposed than the other models touched by
5fcf891, because user may search for 'Created
by' in the web client.

closes #40130

X-original-commit: b3c539b
Signed-off-by: Yannick Tivisse (yti) <>
@robodoo robodoo removed the CI 🤖 label Nov 12, 2019
Feyensv and others added 3 commits Nov 12, 2019
When assigning a default value to a computed monetary field, if self
contains records with different currencies, the assignation will fail
when trying to round the value (because self[currency_field] is a
recordset of multiple currencies).

Globally, assigning a monetary value to records in different currencies
should never happen.  The only case we want to support is defaulting a
computed monetary to 0.0.

Add clear error when trying to set monetaries in multi-currency.

closes #40128

Signed-off-by: Raphael Collet (rco) <>
Co-authored-by: Raphael Collet <>
In IE Edge async and await are supported, but guardedCatch is added to
polyfilled MyPromise object and async methods return original Promise so
depending of chain guardedCatch can cause en error or not.

It seems that historically, the MyPromise patching has also had issue in
firefox with it sometimes working or not.

In this changeset we completely remove it (which will have the drawback
of more error shown in console in firefox).

closes #39953

Signed-off-by: Nicolas Lempereur (nle) <>

Fine tuning of this commit: f93fcaf

Steps to reproduce the bug:

- Open runbot v11
- Restrict Demo's access to Sales Manager for sales and employee for Employee
- Try to create a new quotation

- You got Odoo server Error
Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that:
- Inventory/User
- Accounting & Finance/Billing
- Purchases/User
- Purchases/Manager
- Other Extra Rights/Portal
(Document model: purchase.order.line) - (Operation: read, User: 5)


closes #40149

X-original-commit: 1b14af2
Signed-off-by: Simon Goffin (sig) <>
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 12, 2019
self.env.user returns the current user but browsed with the superuser:
- self.env.user == current user
- self.env.user.env.user == administrator

get_context uses self.env.user to retrieve the context of the user.
Before this patch, the name of the filters was translated in the
language of the administrator instead of the current user.

Closes #40086

closes #40142

Signed-off-by: Martin Trigaux (mat) <>
@robodoo robodoo removed the CI 🤖 label Nov 13, 2019
oco-odoo and others added 2 commits Nov 12, 2019
Before that, draft entries were taken into account in reconciliation propositions; which made no sense.

13.0 version of #39954

closes #40167

Signed-off-by: Laurent Smet <>
In 4d5c3b9 the arguments of the MenuEntryDialog widget were
altered, and one instantiation of this widget was not adapted, resulting
in the last parameter being undefined and causing a crash. This commit
adapts that call.

closes #40171

Signed-off-by: Jérémy Kersten (jke) <>
@robodoo robodoo added the CI 🤖 label Nov 13, 2019
Introduced by ab483a3
There was no way to exit the 'cancelled' state of an account.payment.
The new live-cycle is:
- draft -> posted -> sent -> reconciled -> cancelled
- action_draft to move the account.payment from ('cancelled', 'posted', 'sent', 'reconciled') -> 'draft'
- cancel to move the account.payment from 'draft' -> 'cancel'

closes #40179

Signed-off-by: oco-odoo <>
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 13, 2019
qsm-odoo and others added 2 commits Nov 13, 2019
closes #40184

Signed-off-by: Quentin Smetz (qsm) <>
Make sure to update the standard price with the computed unit cost of
the candidate and not its `unit_cost` field, as the computed could
contain an extra value from a landed cost.

closes #40185

Signed-off-by: Simon Lejeune (sle) <>
@robodoo robodoo removed the CI 🤖 label Nov 13, 2019
fw-bot and others added 6 commits Nov 4, 2019
Without this commit, if you have the hr_timesheet installed, the one2many analytic lines view (in the Journal Items form) shows the hr_timesheet_line_tree view instead, which is not desired.

closes #40189

X-original-commit: 0b92bde
Signed-off-by: Quentin De Paoli (qdp) <>
There is a constrains preventing writing debit/credit on an already
reconciled journal item. However, this constraint isn't aware about
monetary fields and then, was raising an error when writing amount
like 1.000001 on a debit of 1.0.

closes #40182

Signed-off-by: oco-odoo <>
- Create a Sale Order with a product
- Confirm and deliver the product, create an invoice.
- Cancel that invoice, go back to the SO.
- Recreate the invoice, you have 2 of them (one cancelled).
- Post the second, and try 'Send and print' and 'Preview'.

A traceback is raised.

The traceback arises because we sort on the `invoice_date`, which is
`False` for a canceled invoice.

Actually, we should not take into account canceled invoices.


closes #40192

Signed-off-by: Nicolas Martinelli (nim) <>
- Create a contact
- Create a child contact without name

Opening POS causes an error as the Name Field is not a string.


closes #40203

Signed-off-by: Nicolas Martinelli (nim) <>
Changing the filter color and its intensity was not working anymore
because of failed JS refactoring when the logic was shared for both
blog posts and events in website.

closes #40217

Signed-off-by: Quentin Smetz (qsm) <>
Planning the workorders depends on the quantity to produce of those workorder
This will create as much as production batch needed regarding the workcenter

This method is good except in case of product tracked by serial number. In that
case the quantity to produce on the workorders is force to 1 regardless of
the quantity to produce on the production

closes #39857

Signed-off-by: Arnold Moyaux <>
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
You can’t perform that action at this time.