Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[IMP] bus: notify user when assets have changed #39875
This not a portal/website feature either
KangOl left a comment
I don't like your approach to triggering the change on the bus.
Why not directly push the notification on the bus (it only be sent once the cursor is committed)
The js code should then be adapted as a bus message will only contain 1 update (instead of a dict with all changes)
Can you also change the notification shown to the user to not talk about "code"? It's too cryptic for end-users.
Use case: When the server is restarted, the python is updated, but some users may have an ongoing session in a browser tab This may lead to code being unsynchronized and ultimately to some odd bugs Purpose: When we are in such a case, notify connected users that assets have changed And propose them to reload the page Known caveats: - This is not a developer's feature Since assets computing is ORM cached, they have limited opportunities to rebuild. Namely, the feature won't trigger each time the JS has changed, rather, it will when JS has changed AND the cache has been reset somehow - This not a portal/website feature either Business clients won't be notified that the JS has changed - While requests debug=assets do trigger a recomputing of the *components* of bundles, they do not save a bundle This means that the requests that sends the notification cannot be debug=assets Task 2034462