Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: wrong domain from dashboard to go to reconcile model #39951

Open
wants to merge 1 commit into
base: 12.0
from

Conversation

@william-andre
Copy link
Contributor

william-andre commented Nov 7, 2019

The domain by default when clicking a button on the dashboard is
('journal_id', '=', self.id) but in this case, the field is not
journal_id but match_journal_id

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@C3POdoo C3POdoo added the RD label Nov 7, 2019
@william-andre william-andre requested a review from qdp-odoo Nov 7, 2019
@@ -107,7 +107,7 @@
<span role="separator">Reconciliation</span>
</div>
<div>
<a role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_account_reconcile_model', 'use_domain': True}" groups="account.group_account_manager">Reconciliation Models</a>
<a role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_account_reconcile_model', 'use_domain': True, 'journal_field': 'match_journal_ids'}" groups="account.group_account_manager">Reconciliation Models</a>

This comment has been minimized.

Copy link
@qdp-odoo

qdp-odoo Nov 8, 2019

Contributor

something like that would be better:

- <a role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_account_reconcile_model', 'use_domain': True, 'journal_field': 'match_journal_ids'}" groups="account.group_account_manager">Reconciliation Models</a>
+ <a role="menuitem" type="object" name="open_action_with_context" context="{'action_name': 'action_account_reconcile_model', 'use_domain': False, 'search_default_matched_journal_id: [self.id]}" groups="account.group_account_manager">Reconciliation Models</a>
@william-andre william-andre force-pushed the odoo-dev:12.0-reconcile-model-dashboard-wan branch from acec00a to 99a20a3 Nov 8, 2019
@robodoo robodoo removed the CI 🤖 label Nov 8, 2019
The domain by default when clicking a button on the dashboard is
`('journal_id', '=', self.id)` but in this case, the field is not
`journal_id` but `match_journal_id`
@william-andre william-andre force-pushed the odoo-dev:12.0-reconcile-model-dashboard-wan branch from 99a20a3 to dd98550 Nov 12, 2019
@robodoo robodoo added the CI 🤖 label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.