Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_it_edi: split name #40037

Closed
wants to merge 1 commit into from

Conversation

@nim-odoo
Copy link
Contributor

nim-odoo commented Nov 8, 2019

Fields Nome and Cognome cannot be identical. However, Odoo has only
a single field for name. Therefore, we split the name based on the
assumption that the name is written as 'Name Surname'.

opw-2093035

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Fields `Nome` and `Cognome` cannot be identical. However, Odoo has only
a single field for name. Therefore, we split the name based on the
assumption that the name is written as 'Name Surname'.

opw-2093035
@nim-odoo nim-odoo self-assigned this Nov 8, 2019
@robodoo robodoo added the seen 🙂 label Nov 8, 2019
@nim-odoo nim-odoo requested a review from jco-odoo Nov 8, 2019
@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Nov 8, 2019

This works for 'John Doe' or 'John Doe Smith' but will fail for 'John' or 'Doe John'. I don't see a better solution though.

@C3POdoo C3POdoo added the OE label Nov 8, 2019
@robodoo robodoo added the CI 🤖 label Nov 8, 2019
@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Nov 13, 2019

@nim-odoo The first join looks like a bit of overkill, but the idea of the solution is fine by me. @jbm-odoo You would not remember anything that goes against splitting it like this?

Copy link
Contributor Author

nim-odoo left a comment

robodoo r+

@robodoo robodoo added the r+ 👌 label Nov 13, 2019
robodoo pushed a commit that referenced this pull request Nov 13, 2019
Fields `Nome` and `Cognome` cannot be identical. However, Odoo has only
a single field for name. Therefore, we split the name based on the
assumption that the name is written as 'Name Surname'.

opw-2093035

closes #40037

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
robodoo pushed a commit that referenced this pull request Nov 13, 2019
Fields `Nome` and `Cognome` cannot be identical. However, Odoo has only
a single field for name. Therefore, we split the name based on the
assumption that the name is written as 'Name Surname'.

opw-2093035

closes #40037

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Nov 13, 2019

Merged at 9e8b33d, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.