Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_timesheet: Avoid generated tasks on Undefined stage #40040

Closed
wants to merge 1 commit into from

Conversation

@tivisse
Copy link
Contributor

tivisse commented Nov 8, 2019

Purpose

Steps to reproduce:

  • Configure a product of type service to create a task on a
    sales order validation, without configuring a project template
  • On the SO confirmation, the project is generated without any stages

Additional issue:

  • go to the Kanban view of the Project
  • filter on something that doesn't give any result
  • The kanban switches to edit mode, even if there is
    a task

This commit solves both issues.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Purpose
=======

Steps to reproduce:

- Configure a product of type service to create a task on a
  sales order validation, without configuring a project template
- On the SO confirmation, the project is generated without any stages

Additional issue:
- go to the Kanban view of the Project
- filter on something that doesn't give any result
- The kanban switches to edit mode, even if there is
  a task

This commit solves both issues.
@robodoo robodoo added the seen 🙂 label Nov 8, 2019
@C3POdoo C3POdoo added the RD label Nov 8, 2019
@robodoo robodoo added the CI 🤖 label Nov 8, 2019
@tivisse

This comment has been minimized.

Copy link
Contributor Author

tivisse commented Nov 8, 2019

@robodoo robodoo added the r+ 👌 label Nov 8, 2019
robodoo pushed a commit that referenced this pull request Nov 8, 2019
Purpose
=======

Steps to reproduce:

- Configure a product of type service to create a task on a
  sales order validation, without configuring a project template
- On the SO confirmation, the project is generated without any stages

Additional issue:
- go to the Kanban view of the Project
- filter on something that doesn't give any result
- The kanban switches to edit mode, even if there is
  a task

This commit solves both issues.

closes #40040

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
@robodoo robodoo added the merging 👷 label Nov 8, 2019
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Nov 8, 2019

Merged at e2de633, thanks!

@fw-bot

This comment has been minimized.

Copy link
Contributor

fw-bot commented Nov 12, 2019

This pull request has forward-port PRs awaiting action (not merged or closed): #40056, #40057

@tivisse tivisse deleted the odoo-dev:saas-12.3-project-fix-yti branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.