Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sms: send to oneself #40650

Closed

Conversation

@Florimond
Copy link
Contributor

Florimond commented Nov 21, 2019

After this commit:
the author of an sms can send it to himself

@robodoo robodoo added the seen 🙂 label Nov 21, 2019
@C3POdoo C3POdoo added the RD label Nov 21, 2019
@robodoo robodoo added the CI 🤖 label Nov 21, 2019
Currently discuss post (through mail or sms) does not allow the author
to be notified of its content, as

  * he posted it and is therefore already updated;
  * it could create email loops;

However with SMS one could easily try to send SMS to himself using the
sms composer that is different from the mail composer. In that case
just use the ``mail_notify_author`` context key allowing to bypass the
"no author notification" rule.

Task ID 2091685
PR #40650
@tde-banana-odoo tde-banana-odoo force-pushed the odoo-dev:master-sms-send-to-oneself-fhu branch from 9c7b018 to a188ced Dec 2, 2019
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Dec 2, 2019

@robodoo robodoo added r+ 👌 CI 🤖 and removed CI 🤖 labels Dec 2, 2019
robodoo pushed a commit that referenced this pull request Dec 2, 2019
Currently discuss post (through mail or sms) does not allow the author
to be notified of its content, as

  * he posted it and is therefore already updated;
  * it could create email loops;

However with SMS one could easily try to send SMS to himself using the
sms composer that is different from the mail composer. In that case
just use the ``mail_notify_author`` context key allowing to bypass the
"no author notification" rule.

Task ID 2091685
PR #40650

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@robodoo robodoo closed this Dec 2, 2019
@robodoo robodoo deployed to merge Dec 2, 2019 Active
@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:master-sms-send-to-oneself-fhu branch Dec 3, 2019
bbh-odoo added a commit to odoo-dev/odoo that referenced this pull request Dec 9, 2019
Currently discuss post (through mail or sms) does not allow the author
to be notified of its content, as

  * he posted it and is therefore already updated;
  * it could create email loops;

However with SMS one could easily try to send SMS to himself using the
sms composer that is different from the mail composer. In that case
just use the ``mail_notify_author`` context key allowing to bypass the
"no author notification" rule.

Task ID 2091685
PR odoo#40650

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.