Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_cl - Add attr readonly for l10n_cl_sii_taxpayer_type for res.partner children records, and optimize document type order #40877

Closed
wants to merge 1 commit into from

Conversation

@Danisan
Copy link
Contributor

Danisan commented Nov 26, 2019

Description of the issue/feature this PR addresses:
Change the order of documents, changing the sequence for most used taxable documents in the journals.
In demo data, includes taxpayer type to "1"
Change label to a singular
Optimize view of taxpayer type in view

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Nov 26, 2019
@Danisan

This comment has been minimized.

Copy link
Contributor Author

Danisan commented Nov 26, 2019

@robodoo robodoo added the CI 🤖 label Nov 26, 2019
<field name="country_id" position="after">
<field name="l10n_cl_sii_taxpayer_type"/>
<field name="vat" position="after">
<field name="l10n_cl_sii_taxpayer_type" placeholder="Tax Payer Type"/>

This comment has been minimized.

Copy link
@jco-odoo

jco-odoo Nov 26, 2019

Contributor

Can we add attrs readonly when parent_id != False ?

This comment has been minimized.

Copy link
@jco-odoo

This comment has been minimized.

Copy link
@Danisan

Danisan Nov 27, 2019

Author Contributor

Can we add attrs readonly when parent_id != False ?

@jco-odoo you mean in the l10n_cl_sii_taxpayer_type? I am thinking that in general would be OK.

This comment has been minimized.

Copy link
@Danisan

Danisan Nov 29, 2019

Author Contributor

This comment has been minimized.

Copy link
@jco-odoo

jco-odoo Dec 2, 2019

Contributor

@Danisan attrs="{'readonly': [('parent_id', '!=', False)]}" Can you add it? (because the vat number needs to be the sam for all the "children partners" of a partner)

This comment has been minimized.

Copy link
@Danisan

Danisan Dec 2, 2019

Author Contributor

sorry, fixed at #1a33acc

@robodoo robodoo removed the CI 🤖 label Dec 2, 2019
@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Dec 2, 2019

@Danisan Can you update commit message with [FIX] l10n_cl: .... so we see immediately the module it is about? (then I can merge)

@Danisan

This comment has been minimized.

Copy link
Contributor Author

Danisan commented Dec 2, 2019

@Danisan Can you update commit message with [FIX] l10n_cl: .... so we see immediately the module it is about? (then I can merge)

You 've got it!

@suv-bmya suv-bmya force-pushed the bmya:13.0-fix-tp branch from 726fe6e to 3795360 Dec 2, 2019
@Danisan Danisan changed the title [FIX] l10n_cl [FIX] l10n_cl - Add attr readonly for l10n_cl_sii_taxpayer_type for res.partner son records, and optimize document type order Dec 2, 2019
@Danisan Danisan changed the title [FIX] l10n_cl - Add attr readonly for l10n_cl_sii_taxpayer_type for res.partner son records, and optimize document type order [FIX] l10n_cl - Add attr readonly for l10n_cl_sii_taxpayer_type for res.partner children records, and optimize document type order Dec 2, 2019
@suv-bmya suv-bmya force-pushed the bmya:13.0-fix-tp branch from 3795360 to de17b88 Dec 2, 2019
@Danisan Danisan requested a review from jco-odoo Dec 2, 2019
@robodoo robodoo added the CI 🤖 label Dec 3, 2019
@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Dec 3, 2019

@Danisan please squash into one commit then.

@Danisan Danisan force-pushed the bmya:13.0-fix-tp branch from de17b88 to 198126c Dec 4, 2019
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Dec 4, 2019
Description:
- Add readonly attribute to partner view for l10n_cl_sii_taxpayer_type field for children res.partner records.
- Fix the tax payer type label to prevent usage of "label for.."
- Optimize document type order to put most used on top of file and in selection of document types during invoicing process
@Danisan Danisan force-pushed the bmya:13.0-fix-tp branch from 198126c to d8f5957 Dec 4, 2019
@robodoo robodoo removed the CI 🤖 label Dec 4, 2019
@jco-odoo

This comment has been minimized.

Copy link
Contributor

jco-odoo commented Dec 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.