Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] web, account: fix RTL popover on invoice & fix RTL pivot view dropdown #41200

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Dec 2, 2019

[FIX] web: fix RTL pivot view dropdown

Reproduce the issue

- Load Arabic language
- Install Sales
- Report > Sales
- Switch to arabic
- Click on the pivot view to display the dropdown

The dropdown position is incorrect

Cause

The calculations are based on a `left` value who is weird.

This commit use the mouse X position to compute the left value.


[FIX] web, account: fix RTL popover on invoice

Reproduce the issue

- Load Arabic language
- Install Accounting
- Create an invoice & add credit note
- Switch to arabic
- Click on the "(i)" icon near the total price

The popover is displayed at the other side of the screen

Cause

- RTLcss was reversing the "left: 0" css property to "right: 0"
- The popover configuration was not adapted for RTL

This commit ignore RTL for the popover css "left" property and
configure correctly the JS side

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #41158

jvm-odoo added 2 commits Nov 29, 2019
Reproduce the issue

    - Load Arabic language
    - Install Sales
    - Report > Sales
    - Switch to arabic
    - Click on the pivot view to display the dropdown

    The dropdown position is incorrect

Cause

    The calculations are based on a `left` value who is weird.

This commit use the mouse X position to compute the `left` value.

OPW-2146210

X-original-commit: d021f42
Reproduce the issue

    - Load Arabic language
    - Install Accounting
    - Create an invoice & add credit note
    - Switch to arabic
    - Click on the "(i)" icon near the total price

    The popover is displayed at the other side of the screen

Cause

    - RTLcss was reversing the "left: 0" css property to "right: 0"
    - The popover configuration was not adapted for RTL

This commit ignore RTL for the popover css "left" property and
configure correctly the JS side

OPW-2146210

X-original-commit: 88f03f0
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Dec 2, 2019

Ping @jasonvanmalder
This PR targets master and is the last of the forward-port chain.

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@jvm-odoo

This comment has been minimized.

Copy link
Contributor

jvm-odoo commented Dec 3, 2019

@fw-bot r+

robodoo pushed a commit that referenced this pull request Dec 3, 2019
Reproduce the issue

    - Load Arabic language
    - Install Accounting
    - Create an invoice & add credit note
    - Switch to arabic
    - Click on the "(i)" icon near the total price

    The popover is displayed at the other side of the screen

Cause

    - RTLcss was reversing the "left: 0" css property to "right: 0"
    - The popover configuration was not adapted for RTL

This commit ignore RTL for the popover css "left" property and
configure correctly the JS side

OPW-2146210

closes #41200

X-original-commit: 88f03f0
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>
@robodoo robodoo closed this Dec 3, 2019
@robodoo robodoo deployed to merge Dec 3, 2019 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.