Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] stock_picking_batch #42582

Closed
wants to merge 12 commits into from
Closed

[IMP] stock_picking_batch #42582

wants to merge 12 commits into from

Conversation

svs-odoo
Copy link
Contributor

@svs-odoo svs-odoo commented Jan 2, 2020 •
edited

Improve batch transfers layout and usability.
See commit's messages for more informations.

task-2069646

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 2, 2020
@amoyaux amoyaux changed the title [IMP, REF] stock_picking_batch [IMP] stock_picking_batch Jan 2, 2020
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 2, 2020
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jan 2, 2020
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jan 3, 2020
Whenrow
Whenrow reviewed Jan 6, 2020
View reviewed changes
addons/stock_picking_batch/models/stock_picking_batch.py Outdated
help='Technical field used to compute whether the check availability button should be shown.')
allowed_picking_ids = fields.One2many('stock.picking', compute='_compute_allowed_picking_ids')
move_ids = fields.One2many(
'stock.move', string="Stock moves",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why stock.move.lines are related et stock.moves computed ?

@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 6, 2020
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 6, 2020
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 8, 2020
@svs-odoo svs-odoo force-pushed the master-stock-batch-svs-sle branch 2 times, most recently from 7c8d236 to 67307e3 Compare January 8, 2020 13:24
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 8, 2020
@sle-odoo @svs-odoo
[REF] stock: wording
761f87a 
This is not related to the batch picking task but was found while
testing it.

task-2069646
@sle-odoo @svs-odoo
[REF] stock: header in picking form
a37f8a3 
Only keep buttons in the header to be able to disable them with an xpath
without breaking every attrs elsewhere in the form.

Why? We want to disable these header buttons when opening a picking from
the bach transfer (by clicking on a line on a o2m list).

task-2069646
@sle-odoo @svs-odoo
[REF] stock_picking_batch: stock picking to its own file
9789fe6 
task-2069646
@sle-odoo @svs-odoo
[REF] stock_picking_batch: report improvements
572ff1f 
wording

task-2069646
@sle-odoo @svs-odoo
[IMP] stock_picking_batch: add to batch wizard improvements
90db361 
We check the selected pickings are compatible to be attached to an
existing batch transfer.

We add the possibility to create on the fly a batch picking to attach
the selected pickings.

task-2069646
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 31, 2020
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Jan 31, 2020
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Jan 31, 2020
sle-odoo and others added 7 commits January 31, 2020 13:40
@sle-odoo @svs-odoo
[IMP] stock_picking_batch: display moves and move lines
3ed5a39 
* allow to directly edit the move lines of the batched transfers
* add a check availability button if any move is not assigned yet

task-2069646
@amoyaux @svs-odoo
[FIX] stock: do not unreserve proccessed move line
18d611c 
When a user unreserve a picking or a move it will
drop all the linked move lines. However it could
happens that some move line already have a done quantity
and the user won't lose this information.

This commit filters move lines in order to only drop
the move line without quantity done and remove the
reserved quantity on others.

Joint work with William Henrotin <whe@odoo.com>

task-2069646
@svs-odoo
[FIX] stock_picking_batch: report by locations
5bad427 
This commit make sure the picking batch report print will be sorted by
location name.

task-2069646
@svs-odoo
[IMP] stock_picking_batch: compute state
d778b07 
About the batch picking state, makes it canceled if all its pickings are
canceled, and makes it done if all its non-canceled pickings are done.
@svs-odoo
[FIX] stock: show move lines with quantity done
42f21fb 
Before this commit, pickings of picking type with `show_reserved` on
False don't show pre-fill moves -what is expected- even if those
pre-fill moves have quantity done -what is less wanted and can happened,
with stock_barcode for example.

With this commit, we continue to hide pre-fill moves for this kind of
picking, except for pre-fill moves who have a quantity done.
@svs-odoo
[IMP] stock_picking_batch: default search filter
17da6e5 
By default, display also draft picking batchs.

task-2123726
@svs-odoo
[REM] mrp: remove _decrease_reserved_quanity
f1f0d80 
As `_do_unreserve` was rewrited, the `_decrease_reserved_quanity` method
isn't useful since its purpose was to avoid to unlink all stock moves
and it is what `_do_unreserve` cares about.

See 2e41338
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Jan 31, 2020
@sle-odoo
Copy link
Contributor

robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Jan 31, 2020

Merge method set to rebase and fast-forward

robodoo pushed a commit that referenced this pull request Jan 31, 2020
@svs-odoo
[REM] mrp: remove _decrease_reserved_quanity
7856220 
As `_do_unreserve` was rewrited, the `_decrease_reserved_quanity` method
isn't useful since its purpose was to avoid to unlink all stock moves
and it is what `_do_unreserve` cares about.

See 2e41338

closes #42582

Related: odoo/enterprise#7488
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
@robodoo robodoo closed this Jan 31, 2020
@robodoo robodoo temporarily deployed to merge January 31, 2020 16:33 Inactive
@fw-bot fw-bot deleted the master-stock-batch-svs-sle branch February 14, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoyaux amoyaux amoyaux left review comments

@sle-odoo sle-odoo sle-odoo left review comments

@Whenrow Whenrow Whenrow left review comments

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@svs-odoo @sle-odoo @robodoo @amoyaux @Whenrow @C3POdoo