Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_picking_batch #42582

Open
wants to merge 12 commits into
base: master
from
Open

Conversation

@svs-odoo
Copy link
Contributor

svs-odoo commented Jan 2, 2020

Improve batch transfers layout and usability.
See commit's messages for more informations.

task-2069646

@robodoo robodoo added the seen 🙂 label Jan 2, 2020
@C3POdoo C3POdoo added the RD label Jan 2, 2020
@amoyaux amoyaux changed the title [IMP, REF] stock_picking_batch [IMP] stock_picking_batch Jan 2, 2020
@robodoo robodoo added the CI 🤖 label Jan 2, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from e376432 to 71d2a66 Jan 2, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 2, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from 71d2a66 to ee115e1 Jan 3, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 3, 2020
help='Technical field used to compute whether the check availability button should be shown.')
allowed_picking_ids = fields.One2many('stock.picking', compute='_compute_allowed_picking_ids')
move_ids = fields.One2many(
'stock.move', string="Stock moves",

This comment has been minimized.

Copy link
@Whenrow

Whenrow Jan 6, 2020

Contributor

Why stock.move.lines are related et stock.moves computed ?

@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from ee115e1 to 76c45e0 Jan 6, 2020
@robodoo robodoo removed the CI 🤖 label Jan 6, 2020
@robodoo robodoo added the CI 🤖 label Jan 6, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from 76c45e0 to d8cd621 Jan 8, 2020
@robodoo robodoo removed the CI 🤖 label Jan 8, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch 2 times, most recently from 7c8d236 to 67307e3 Jan 8, 2020
@robodoo robodoo added the CI 🤖 label Jan 8, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 9, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from f50568b to f4dd7ed Jan 10, 2020
@robodoo robodoo removed the CI 🤖 label Jan 10, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch 2 times, most recently from d1115e2 to 0aee029 Jan 10, 2020
@robodoo robodoo added the CI 🤖 label Jan 10, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from 0aee029 to 0dd7851 Jan 13, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 13, 2020
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from 0dd7851 to 19dc0cd Jan 14, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 14, 2020
sle-odoo and others added 12 commits Oct 21, 2019
This is not related to the batch picking task but was found while
testing it.

task-2069646
Only keep buttons in the header to be able to disable them with an xpath
without breaking every attrs elsewhere in the form.

Why? We want to disable these header buttons when opening a picking from
the bach transfer (by clicking on a line on a o2m list).

task-2069646
* allow to directly edit the move lines of the batched transfers
* add a check availability button if any move is not assigned yet

task-2069646
We check the selected pickings are compatible to be attached to an
existing batch transfer.

We add the possibility to create on the fly a batch picking to attach
the selected pickings.

task-2069646
When a user unreserve a picking or a move it will
drop all the linked move lines. However it could
happens that some move line already have a done quantity
and the user won't lose this information.

This commit filters move lines in order to only drop
the move line without quantity done and remove the
reserved quantity on others.

Joint work with William Henrotin <whe@odoo.com>

task-2069646
This commit make sure the picking batch report print will be sorted by
location name.

task-2069646
About the batch picking state, makes it canceled if all its pickings are
canceled, and makes it done if all its non-canceled pickings are done.
Before this commit, pickings of picking type with `show_reserved` on
False don't show pre-fill moves -what is expected- even if those
pre-fill moves have quantity done -what is less wanted and can happened,
with stock_barcode for example.

With this commit, we continue to hide pre-fill moves for this kind of
picking, except for pre-fill moves who have a quantity done.
By default, display also draft picking batchs.

task-2123726
As `_do_unreserve` was rewrited, the `_decrease_reserved_quanity` method
isn't useful since its purpose was to avoid to unlink all stock moves
and it is what `_do_unreserve` cares about.

See 2e41338
@svs-odoo svs-odoo force-pushed the odoo-dev:master-stock-batch-svs-sle branch from 19dc0cd to 7692537 Jan 14, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.