Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] l10n_ch: don't assume the bank account of the company always has a currency_id #43282

Closed
wants to merge 1 commit into from

Conversation

@oco-odoo
Copy link
Contributor

oco-odoo commented Jan 14, 2020

Since this field is not required on res.partner.bank (which is fine: we want it to be synchronized with the journal's currency, which is None if the journal uses company currency), the parameter received by validate_swiss_code_arguments ended out being an empty recordset in case the company was directly in CHF. This caused the QR code to never be displayed in this situation.

…s a currency_id

Since this field is not required on res.partner.bank (which is fine: we want it to be synchronized with the journal's currency, which is None if the journal uses company currency), the parameter received by validate_swiss_code_arguments ended out being an empty recordset in case the company was directly in CHF. This caused the QR code to never be displayed in this situation.
@oco-odoo oco-odoo requested a review from smetl Jan 14, 2020
@C3POdoo C3POdoo added the RD label Jan 14, 2020
@smetl
smetl approved these changes Jan 15, 2020
Copy link
Contributor

smetl left a comment

@robodoo robodoo added the r+ 👌 label Jan 15, 2020
robodoo pushed a commit that referenced this pull request Jan 15, 2020
…s a currency_id

Since this field is not required on res.partner.bank (which is fine: we want it to be synchronized with the journal's currency, which is None if the journal uses company currency), the parameter received by validate_swiss_code_arguments ended out being an empty recordset in case the company was directly in CHF. This caused the QR code to never be displayed in this situation.

closes #43282

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
@robodoo robodoo closed this Jan 15, 2020
@robodoo robodoo deployed to merge Jan 15, 2020 Active
mstuttgart added a commit to multidadosti-erp/odoo that referenced this pull request Jan 15, 2020
…s a currency_id

Since this field is not required on res.partner.bank (which is fine: we want it to be synchronized with the journal's currency, which is None if the journal uses company currency), the parameter received by validate_swiss_code_arguments ended out being an empty recordset in case the company was directly in CHF. This caused the QR code to never be displayed in this situation.

closes odoo#43282

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.