Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] core: chrome doesn't abide by --http-port anymore #43283

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Jan 14, 2020

An http-port provided on the command line (may also have been an issue
for config files, didn't check) would not be taken in account anymore,
because odoo.tests.common would be imported during the import of
odoo itself (when loading odoo.service.server), itself importing
odoo.tools.config leading to a default configuration being set up.

  • remove odoo.tests.common.PORT, config['http_port'] should be
    used always
  • defer the import of odoo.tests.common by moving it inside
    load_test_file
  • stop generating default configs

Forward-Port-Of: #43135

An http-port provided on the command line (may also have been an issue
for config files, didn't check) would not be taken in account anymore,
because `odoo.tests.common` would be imported during the import of
`odoo` itself (when loading odoo.service.server), itself importing
`odoo.tools.config` leading to a default configuration being set up.

* remove `odoo.tests.common.PORT`, `config['http_port']` should be
  used always
* defer the import of odoo.tests.common by moving it inside
  load_test_file
* stop generating default configs

X-original-commit: 45871f4
@robodoo robodoo added the seen 🙂 label Jan 14, 2020
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Jan 14, 2020

Ping @xmo-odoo
This PR targets master and is the last of the forward-port chain.

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport label Jan 14, 2020
@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

xmo-odoo commented Jan 14, 2020

@fw-bot r+

robodoo pushed a commit that referenced this pull request Jan 14, 2020
An http-port provided on the command line (may also have been an issue
for config files, didn't check) would not be taken in account anymore,
because `odoo.tests.common` would be imported during the import of
`odoo` itself (when loading odoo.service.server), itself importing
`odoo.tools.config` leading to a default configuration being set up.

* remove `odoo.tests.common.PORT`, `config['http_port']` should be
  used always
* defer the import of odoo.tests.common by moving it inside
  load_test_file
* stop generating default configs

closes #43283

X-original-commit: 45871f4
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@C3POdoo C3POdoo added the RD label Jan 14, 2020
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Jan 14, 2020

Staging failed: ci/runbot on a984c5bceb94f9c842dc35d125849f7451f0c95b (view more at http://runbot.odoo.com/runbot/build/871503)

@xmo-odoo

This comment has been minimized.

Copy link
Collaborator

xmo-odoo commented Jan 15, 2020

@robodoo retry

robodoo pushed a commit that referenced this pull request Jan 15, 2020
An http-port provided on the command line (may also have been an issue
for config files, didn't check) would not be taken in account anymore,
because `odoo.tests.common` would be imported during the import of
`odoo` itself (when loading odoo.service.server), itself importing
`odoo.tools.config` leading to a default configuration being set up.

* remove `odoo.tests.common.PORT`, `config['http_port']` should be
  used always
* defer the import of odoo.tests.common by moving it inside
  load_test_file
* stop generating default configs

closes #43283

X-original-commit: 45871f4
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
@robodoo robodoo closed this Jan 15, 2020
@robodoo robodoo deployed to merge Jan 15, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.