Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: list price display after tax mapping #43284

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Jan 14, 2020

  • In general settings:
    • Sales:
      • Activate discount
      • Activate Multiple Sale Prices with option computed from formula
    • Point of sale:
      • Activate Multiple Sale Prices with option computed from formula
    • Accounting:
      • Set show price tax-included
  • Modify the Public Pricelist: Set to Global, price discount 50%
  • Modify the sale tax to be included in price
  • Create a 0% tax included in price
  • Open fiscal position: Set auto-detect, replace sale 15% by 0%
  • Open a product and set customer tax to sale 15%
  • Open POS session configuration
    • Set fiscal position, tax included in price and public pricelist
  • Add product "Pedal Bin"

You will see in strikethough text the original selling price with tax included,
while taxes should have been removed from the tax mapping.
Note that this is purely aesthetical, the total amount calculated is correct.
Fixing by calculating the price from the original selling price.

opw-2155779

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #43259
Forward-Port-Of: #43112

- In general settings:
    - Sales:
        - Activate discount
        - Activate Multiple Sale Prices with option computed from formula
    - Point of sale:
        - Activate Multiple Sale Prices with option computed from formula
    - Accounting:
        - Set show price tax-included
- Modify the Public Pricelist: Set to Global, price discount 50%
- Modify the sale tax to be included in price
- Create a 0% tax included in price
- Open fiscal position: Set auto-detect, replace sale 15% by 0%
- Open a product and set customer tax to sale 15%
- Open POS session configuration
    - Set fiscal position, tax included in price and public pricelist
- Add product "Pedal Bin"

You will see in strikethough text the original selling price with tax included,
while taxes should have been removed from the tax mapping.
Note that this is purely aesthetical, the total amount calculated is correct.
Fixing by calculating the price from the original selling price.

opw-2155779

X-original-commit: 7de221c
@robodoo robodoo added the seen 🙂 label Jan 14, 2020
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Jan 14, 2020

Ping @agr-odoo, @nle-odoo
This PR targets master and is the last of the forward-port chain containing:

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@agr-odoo

This comment has been minimized.

Copy link
Contributor

agr-odoo commented Jan 20, 2020

@nle-odoo should be ok

@nle-odoo

This comment has been minimized.

Copy link
Contributor

nle-odoo commented Jan 20, 2020

fw-bot r+

@robodoo robodoo added the r+ 👌 label Jan 20, 2020
robodoo pushed a commit that referenced this pull request Jan 20, 2020
- In general settings:
    - Sales:
        - Activate discount
        - Activate Multiple Sale Prices with option computed from formula
    - Point of sale:
        - Activate Multiple Sale Prices with option computed from formula
    - Accounting:
        - Set show price tax-included
- Modify the Public Pricelist: Set to Global, price discount 50%
- Modify the sale tax to be included in price
- Create a 0% tax included in price
- Open fiscal position: Set auto-detect, replace sale 15% by 0%
- Open a product and set customer tax to sale 15%
- Open POS session configuration
    - Set fiscal position, tax included in price and public pricelist
- Add product "Pedal Bin"

You will see in strikethough text the original selling price with tax included,
while taxes should have been removed from the tax mapping.
Note that this is purely aesthetical, the total amount calculated is correct.
Fixing by calculating the price from the original selling price.

opw-2155779

closes #43284

X-original-commit: 7de221c
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
robodoo pushed a commit that referenced this pull request Jan 20, 2020
- In general settings:
    - Sales:
        - Activate discount
        - Activate Multiple Sale Prices with option computed from formula
    - Point of sale:
        - Activate Multiple Sale Prices with option computed from formula
    - Accounting:
        - Set show price tax-included
- Modify the Public Pricelist: Set to Global, price discount 50%
- Modify the sale tax to be included in price
- Create a 0% tax included in price
- Open fiscal position: Set auto-detect, replace sale 15% by 0%
- Open a product and set customer tax to sale 15%
- Open POS session configuration
    - Set fiscal position, tax included in price and public pricelist
- Add product "Pedal Bin"

You will see in strikethough text the original selling price with tax included,
while taxes should have been removed from the tax mapping.
Note that this is purely aesthetical, the total amount calculated is correct.
Fixing by calculating the price from the original selling price.

opw-2155779

closes #43284

X-original-commit: 7de221c
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Jan 20, 2020
@robodoo robodoo closed this Jan 20, 2020
@robodoo robodoo deployed to merge Jan 20, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.