Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[FIX] ir_property: Allows to search on boolean == False #43580
Closed
+7
−1
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Forgot the inverse operator. Fixed |
|
LGTM, thanks |
This comment has been minimized.
This comment has been minimized.
|
On its way to be merged ? |
This comment has been minimized.
This comment has been minimized.
|
Sure! |
rousseldenis
added a commit
to acsone/odoo
that referenced
this pull request
Feb 3, 2020
Closes odoo#43580 Fixes odoo#9449 Adds field type conditions for boolean in search for Property model. As False values are not stored in DB for boolean, the search() does not return any value for non existent lines with: * operator: '=' and value: False * operator: '!=' and value: True Uses the 'include_zero' and inverse operator mechanisms implmented in Property model.
56b09c6
to
4981171
Closes #43580 Fixes #9449 Adds field type conditions for boolean in search for Property model. As False values are not stored in DB for boolean, the search() does not return any value for non existent lines with: * operator: '=' and value: False * operator: '!=' and value: True Uses the 'include_zero' and inverse operator mechanisms implemented in Property model.
4981171
to
4038cf0
This comment has been minimized.
This comment has been minimized.
|
@mart-e Done ! |
This comment has been minimized.
This comment has been minimized.
|
Great, thanks ! @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 3, 2020
Closes #43580 Fixes #9449 Adds field type conditions for boolean in search for Property model. As False values are not stored in DB for boolean, the search() does not return any value for non existent lines with: * operator: '=' and value: False * operator: '!=' and value: True Uses the 'include_zero' and inverse operator mechanisms implemented in Property model. Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rousseldenis commentedJan 20, 2020
Description of the issue/feature this PR addresses:
This is related to an oooold bug that does not allow to search False on boolean company_dependent fields.
See: #9449
Current behavior before PR:
The search does not work
Desired behavior after PR is merged:
The search is working
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr