Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: prevent group payment if multiple receivable/payable a… #44130

Conversation

@alt-odoo
Copy link
Contributor

alt-odoo commented Jan 28, 2020

…ccounts

When creating a payment, we are expecting only one destination account. However, when
grouping payment by customer, it can happen that there are more than one receivable
or payable accounts, which can create reconciliation issues afterward.

Description of the issue/feature this PR addresses:
opw-2166551

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Jan 28, 2020
@C3POdoo C3POdoo added the OE label Jan 28, 2020
@alt-odoo alt-odoo force-pushed the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch 3 times, most recently from 4cb9a08 to 6be0af2 Jan 29, 2020
@robodoo robodoo added the CI 🤖 label Jan 29, 2020
@jpp-odoo jpp-odoo force-pushed the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch from 6be0af2 to 446983d Feb 14, 2020
@robodoo robodoo removed the CI 🤖 label Feb 14, 2020
@jpp-odoo

This comment has been minimized.

Copy link
Contributor

jpp-odoo commented Feb 14, 2020

@nim-odoo LGTM! What do you think ?

@jpp-odoo

This comment has been minimized.

Copy link
Contributor

jpp-odoo commented Feb 14, 2020

@robodoo robodoo added the CI 🤖 label Feb 14, 2020
@jpp-odoo jpp-odoo force-pushed the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch from 446983d to df3d72c Feb 14, 2020
@robodoo robodoo removed the CI 🤖 label Feb 14, 2020
@jpp-odoo jpp-odoo force-pushed the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch from df3d72c to 225cee7 Feb 14, 2020
…ccounts

When creating a payment, we are expecting only one destination account.
However, when grouping payment by customer, it can happen that there are
more than one receivable or payable accounts, which can create
reconciliation issues afterward.

opw-2188632
opw-2166551

Co-authored-by: Jorge Pinna Puissant <jpp@odoo.com>
@jpp-odoo jpp-odoo force-pushed the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch from 225cee7 to 191c4ef Feb 14, 2020
@robodoo robodoo added the CI 🤖 label Feb 14, 2020
@jpp-odoo

This comment has been minimized.

Copy link
Contributor

jpp-odoo commented Feb 14, 2020

@nim-odoo I just made the changes you asked for

Copy link
Contributor

nim-odoo left a comment

robodoo r+

@alt-odoo

This comment has been minimized.

Copy link
Contributor Author

alt-odoo commented Feb 14, 2020

@nim-odoo

Even if this build was green, I think we should still adapt the test as it was crashing a couple of weeks, see the previous run :
http://runbot.odoo.com/runbot/build/1036951

It might create unnecessary blocking error later, what do you think?

@jpp-odoo

This comment has been minimized.

Copy link
Contributor

jpp-odoo commented Feb 14, 2020

@alt-odoo The UserError is not in the sameplace anymore, now is in the Wizard. Is for this reason that we don't need to change the tests anymore.

@jpp-odoo jpp-odoo deleted the odoo-dev:13.0-prevent-register-group-payment-multiple-dest-accounts-alt branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.