Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE][FIX] (website_)event(_question/_track): provide fixes related to 13.2 event upgrades #44545

Closed

Conversation

@std-odoo
Copy link
Contributor

std-odoo commented Feb 4, 2020

Purpose

Fix kanban state default value and display in community.

Fix question answers not correctly parsed from frontend.

Fix sale availability ACLs issue when having tickets.

Do not group the event tracks by location.

See sub commits for more details.

Task 2188857
PR #44545

@robodoo robodoo added the seen 🙂 label Feb 4, 2020
@std-odoo std-odoo changed the title Master event small fixes 2020 02 std [FIX] event(_*): small fixes Feb 4, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch from d9ba82c to b85686d Feb 4, 2020
@C3POdoo C3POdoo added the RD label Feb 4, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch 4 times, most recently from f44670f to 12d2af9 Feb 4, 2020
@robodoo robodoo added the CI 🤖 label Feb 5, 2020
@std-odoo std-odoo changed the base branch from master to saas-13.2 Feb 6, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch from 12d2af9 to b4364ca Feb 7, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 7, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch from c48a6a9 to 2c48662 Feb 10, 2020
@robodoo robodoo removed the CI 🤖 label Feb 10, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch 4 times, most recently from 0377117 to 0cc6d29 Feb 10, 2020
@robodoo robodoo added the CI 🤖 label Feb 10, 2020
Copy link
Contributor

tde-banana-odoo left a comment

Tech review

Side note: try to improve commit message, notably commit headers (fix answers -> correctly parse frontend question answers for example)

addons/website_event/controllers/main.py Outdated Show resolved Hide resolved
addons/event_sale/models/event_ticket.py Outdated Show resolved Hide resolved
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch from 0cc6d29 to a90f7a5 Feb 12, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 12, 2020
@std-odoo std-odoo force-pushed the odoo-dev:master-event-small-fixes-2020-02-std branch from a90f7a5 to 41ba63f Feb 13, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 13, 2020
Copy link
Contributor

tde-banana-odoo left a comment

I have a dream... doubt ! Just check for individual / grouped answers as code seems a bit louche.

@robodoo robodoo removed the CI 🤖 label Feb 18, 2020
@tde-banana-odoo

This comment has been minimized.

Copy link
Contributor

tde-banana-odoo commented Feb 18, 2020

@robodoo r+ rebase-merge

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 18, 2020

Merge method set to rebase and merge, using the PR as merge commit message

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 18, 2020

Linked pull request(s) odoo/enterprise#8147 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Feb 18, 2020
In the event form view, when only community is installed, kanban state
is not on the right part of the form.

Moreover it should have a default value.

Task 2188857
PR #44545
robodoo pushed a commit that referenced this pull request Feb 18, 2020
…swers

When user register to an event from website, they can answer questions
specific to a given registration or to all registrations. However they
are not correctly parsed and not saved.

Task 2188857
PR #44545
robodoo pushed a commit that referenced this pull request Feb 18, 2020
Indeed this field is notably based on tickets availability. Reading tickets
products is not necessarily granted to everyone. People reading events should
be able to know if the sale is available or not independently of their access
on product model. Let us therefore use a compute sudo.

Task 2188857
PR #44545
robodoo pushed a commit that referenced this pull request Feb 18, 2020
Because it is counter intuitive for track managers.

Task 2188857
PR #44545
robodoo pushed a commit that referenced this pull request Feb 18, 2020
When we buy a ticket on website, a sale order is automatically created and
confirmed if the ticket is free. When we buy a second ticket we will edit the
old SO, but we can't, because the SO was confirmed.

Solution
========

In `_create_attendees_from_registration_post`, reset the sale information.

Task ID 2188857
PR #44545
robodoo added a commit that referenced this pull request Feb 18, 2020
… to 13.2 event upgrades

Purpose
=======

Fix kanban state default value and display in community.

Fix question answers not correctly parsed from frontend.

Fix sale availability ACLs issue when having tickets.

Do not group the event tracks by location.

See sub commits for more details.

Task 2188857
PR #44545

Related: odoo/enterprise#8147
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2020
In the event form view, when only community is installed, kanban state
is not on the right part of the form.

Moreover it should have a default value.

Task 2188857
PR odoo#44545

X-original-commit: 1813f06
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2020
…swers

When user register to an event from website, they can answer questions
specific to a given registration or to all registrations. However they
are not correctly parsed and not saved.

Task 2188857
PR odoo#44545

X-original-commit: e27d9b5
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2020
Indeed this field is notably based on tickets availability. Reading tickets
products is not necessarily granted to everyone. People reading events should
be able to know if the sale is available or not independently of their access
on product model. Let us therefore use a compute sudo.

Task 2188857
PR odoo#44545

X-original-commit: cfabf12
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2020
Because it is counter intuitive for track managers.

Task 2188857
PR odoo#44545

X-original-commit: 4fcbb83
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2020
When we buy a ticket on website, a sale order is automatically created and
confirmed if the ticket is free. When we buy a second ticket we will edit the
old SO, but we can't, because the SO was confirmed.

Solution
========

In `_create_attendees_from_registration_post`, reset the sale information.

Task ID 2188857
PR odoo#44545

X-original-commit: d0e80ff
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 18, 2020
@robodoo robodoo closed this Feb 18, 2020
@robodoo robodoo deployed to merge Feb 18, 2020 Active
robodoo pushed a commit that referenced this pull request Feb 18, 2020
In the event form view, when only community is installed, kanban state
is not on the right part of the form.

Moreover it should have a default value.

Task 2188857
PR #44545

X-original-commit: 1813f06
robodoo pushed a commit that referenced this pull request Feb 18, 2020
…swers

When user register to an event from website, they can answer questions
specific to a given registration or to all registrations. However they
are not correctly parsed and not saved.

Task 2188857
PR #44545

X-original-commit: e27d9b5
robodoo pushed a commit that referenced this pull request Feb 18, 2020
Indeed this field is notably based on tickets availability. Reading tickets
products is not necessarily granted to everyone. People reading events should
be able to know if the sale is available or not independently of their access
on product model. Let us therefore use a compute sudo.

Task 2188857
PR #44545

X-original-commit: cfabf12
robodoo pushed a commit that referenced this pull request Feb 18, 2020
Because it is counter intuitive for track managers.

Task 2188857
PR #44545

X-original-commit: 4fcbb83
robodoo pushed a commit that referenced this pull request Feb 18, 2020
When we buy a ticket on website, a sale order is automatically created and
confirmed if the ticket is free. When we buy a second ticket we will edit the
old SO, but we can't, because the SO was confirmed.

Solution
========

In `_create_attendees_from_registration_post`, reset the sale information.

Task ID 2188857
PR #44545

X-original-commit: d0e80ff
robodoo added a commit that referenced this pull request Feb 18, 2020
…ated to 13.2 event upgrades

Purpose
=======

Fix kanban state default value and display in community.

Fix question answers not correctly parsed from frontend.

Fix sale availability ACLs issue when having tickets.

Do not group the event tracks by location.

See sub commits for more details.

Task 2188857
PR #44545

closes #45655

Forward-port-of: #44545
Related: odoo/enterprise#8533
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
@tde-banana-odoo tde-banana-odoo deleted the odoo-dev:master-event-small-fixes-2020-02-std branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.