Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] sale: sale_tour selector fix #44964

Conversation

@jhk-odoo
Copy link
Contributor

jhk-odoo commented Feb 10, 2020

Steps to reproduce:

  • install sales
  • go into debug mode
  • dev tools > start tour > sale_tour

Previous behavior:
tour would fail to see that the product has been selected
and time out

Current behavior:
the tour finishes properly

opw-2187218

@robodoo robodoo added the seen 🙂 label Feb 10, 2020
@jhk-odoo

This comment has been minimized.

Copy link
Contributor Author

jhk-odoo commented Feb 10, 2020

@C3POdoo C3POdoo added the OE label Feb 10, 2020
@robodoo robodoo added the CI 🤖 label Feb 10, 2020
@nim-odoo nim-odoo requested a review from nle-odoo Feb 10, 2020
Copy link
Contributor

nle-odoo left a comment

looks good, maybe replace .ui-menu.ui-widget.ui-widget-content by .ui-item-menu, because I'm not sure about .ui-widget-content changing from one jquery-ui version to another, but .ui-menu and .ui-item-menu are documented:

https://api.jqueryui.com/menu/#theming

in commit message it would be nice to say that thanks to your change, the tour now works when you execute a second time manually (and before it only worked the first time)

robodoo delegate+

@jhk-odoo jhk-odoo force-pushed the odoo-dev:13.0-opw-2187218-fix_sale_tour_selectors-jhk branch from f18bc7a to f916e1a Feb 10, 2020
@robodoo robodoo removed the CI 🤖 label Feb 10, 2020
@jhk-odoo

This comment has been minimized.

Copy link
Contributor Author

jhk-odoo commented Feb 10, 2020

@nle-odoo
this fix is not related to the feature request we discussed this morning (execute tours multiple times)
it is to be implemented with this task:
https://www.odoo.com/web?#id=2187222&action=2965&active_id=1544407&model=project.task&view_type=form&menu_id=4720

@jhk-odoo jhk-odoo force-pushed the odoo-dev:13.0-opw-2187218-fix_sale_tour_selectors-jhk branch from f916e1a to 7722d42 Feb 10, 2020
@nle-odoo

This comment has been minimized.

Copy link
Contributor

nle-odoo commented Feb 10, 2020

I think the tour work one time or runbot would be red

the issue is that the tour create a product "DESK0001" but this only work one time because the next time you can't create the "DESK0001" that is already created. So thanks to your fix, the first time the tour is ran "DESK0001" is created and the following times the tour is ran we use the existing "DESK0001"

in the selector:

.ui-menu.ui-widget.ui-item-menu

.ui-menu.ui-widget is parent of .ui-item-menu so this should one of the following instead:

.ui-item-menu
// or
.ui-menu .ui-item-menu
// or
.ui-menu.ui-widget .ui-item-menu
@jhk-odoo jhk-odoo force-pushed the odoo-dev:13.0-opw-2187218-fix_sale_tour_selectors-jhk branch 2 times, most recently from 46042f7 to 9845751 Feb 10, 2020
@jhk-odoo

This comment has been minimized.

Copy link
Contributor Author

jhk-odoo commented Feb 10, 2020

updated

@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Feb 13, 2020

runbot is red

@nle-odoo

This comment has been minimized.

Copy link
Contributor

nle-odoo commented Feb 13, 2020

sorry it's ui-menu-item not ui-item-menu I retyped it wrong in my comment

I just tested now and making the change, the first and next times tour is run, test works

Steps to reproduce:
- install sales
- go into debug mode
- dev tools > start tour > sale_tour

Previous behavior:
tour would fail to see that the product has been selected
and time out if you do it multiple time

Current behavior:
the tour finishes properly (even if it runs multiple times)

opw-2187218
@jhk-odoo jhk-odoo force-pushed the odoo-dev:13.0-opw-2187218-fix_sale_tour_selectors-jhk branch from 9845751 to 9d88ffd Feb 14, 2020
@robodoo robodoo added the CI 🤖 label Feb 14, 2020
@jhk-odoo

This comment has been minimized.

Copy link
Contributor Author

jhk-odoo commented Feb 14, 2020

runbot is green 👍

@nle-odoo

This comment has been minimized.

Copy link
Contributor

nle-odoo commented Feb 14, 2020

robodoo r+

@nle-odoo nle-odoo deleted the odoo-dev:13.0-opw-2187218-fix_sale_tour_selectors-jhk branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.