Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] hr_holidays: fix kanban view date format #45267

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Feb 13, 2020

Issue

- Install Time Off & Studio
- Set up your language to English with format date
  to %d/%m/%y instead of %m/%d/%y
- Enable Kanban view in Time Off dashboard with Studio
- Compare Kanban and List view

The list view dates is correctly formatted but not
the kanban view dates

Cause

We use momentjs which doesn't take the user date format
in account, only the locale.

Solution

Use a field with datetime widget which handle this case.

OPW-2195584

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #45251

@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Feb 13, 2020

This PR targets saas-13.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot-and-Forwardbot#forward-port

@C3POdoo C3POdoo added the OE label Feb 13, 2020
@robodoo robodoo added the r+ 👌 label Feb 13, 2020
robodoo pushed a commit that referenced this pull request Feb 13, 2020
Issue

	- Install Time Off & Studio
	- Set up your language to English with format date
	  to %d/%m/%y instead of %m/%d/%y
	- Enable Kanban view in Time Off dashboard with Studio
	- Compare Kanban and List view

	The list view dates is correctly formatted but not
	the kanban view dates

Cause

	We use momentjs which doesn't take the user date format
	in account, only the locale.

Solution

	Use a field with datetime widget which handle this case.

OPW-2195584

closes #45267

X-original-commit: 69b3578
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 13, 2020

Staging failed: ci/runbot on 074ca36c5b83b999ace2b4e0bfb55f14584f5b0c (view more at http://runbot.odoo.com/runbot/build/1230508)

Issue

	- Install Time Off & Studio
	- Set up your language to English with format date
	  to %d/%m/%y instead of %m/%d/%y
	- Enable Kanban view in Time Off dashboard with Studio
	- Compare Kanban and List view

	The list view dates is correctly formatted but not
	the kanban view dates

Cause

	We use momentjs which doesn't take the user date format
	in account, only the locale.

Solution

	Use a field with datetime widget which handle this case.

OPW-2195584

X-original-commit: 69b3578
@jvm-odoo jvm-odoo force-pushed the odoo-dev:saas-13.1-13.0-opw-2195584-fix-timeoff-kanban-date-jvm-hQNE-fw branch from 08dc405 to 3847855 Feb 14, 2020
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Feb 14, 2020

This PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@robodoo robodoo removed the error 🙅 label Feb 14, 2020
@jvm-odoo

This comment has been minimized.

Copy link
Contributor

jvm-odoo commented Feb 14, 2020

@nim-odoo Should be good I guess

@robodoo robodoo added the CI 🤖 label Feb 14, 2020
@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Feb 14, 2020

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 14, 2020
robodoo pushed a commit that referenced this pull request Feb 14, 2020
Issue

	- Install Time Off & Studio
	- Set up your language to English with format date
	  to %d/%m/%y instead of %m/%d/%y
	- Enable Kanban view in Time Off dashboard with Studio
	- Compare Kanban and List view

	The list view dates is correctly formatted but not
	the kanban view dates

Cause

	We use momentjs which doesn't take the user date format
	in account, only the locale.

Solution

	Use a field with datetime widget which handle this case.

OPW-2195584

closes #45267

X-original-commit: 69b3578
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo closed this Feb 14, 2020
@robodoo robodoo deployed to merge Feb 14, 2020 Active
@nim-odoo

This comment has been minimized.

Copy link
Contributor

nim-odoo commented Feb 14, 2020

fw-bot r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.