Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: fix summernote files showing up in media dialog #45300

Conversation

@sdegueldre
Copy link
Contributor

sdegueldre commented Feb 13, 2020

Due to the infamous web_editor revert, summernote assets files are once
again created and stored in DB, but because they do not contain
'assets_' in their name, they would show up in the media dialog. This
commit fixes that by adding also adding 'summernote' to the assets
domain.

related to #45298 which is the proper fix, but as this is in stable we can't change the template's xml_id. Should only be forward ported to 13.2

Copy link
Contributor

fja-odoo left a comment

Tested: Looks good.
There is a typo in your commit message: 'by adding also adding'
Also maybe add related in your commit message while you are at it !

@C3POdoo C3POdoo added the RD label Feb 13, 2020
@sdegueldre sdegueldre force-pushed the odoo-dev:13.0-web_editor-summernote-assets-in-media-dialog-fix-sad branch from 05cc275 to f301884 Feb 13, 2020
@robodoo robodoo removed the CI 🤖 label Feb 13, 2020
Copy link
Contributor

qsm-odoo left a comment

Could you update commit message to mention the right app? thanks :)

@robodoo robodoo added the CI 🤖 label Feb 13, 2020
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Feb 13, 2020

@fw-bot up to saas-13.2

@fw-bot

This comment has been minimized.

Copy link
Contributor

fw-bot commented Feb 13, 2020

Forward-porting to 'saas-13.2'.

Due to the infamous web_editor revert, summernote assets files are once
again created and stored in DB, but because they do not contain
'assets_' in their name, they would show up in the media dialog. This
commit fixes that by also adding 'summernote' to the assets domain.o

This also means they would not be regenerated by the debug 'regenerate
assets' feature.

Related: #45298
@sdegueldre sdegueldre force-pushed the odoo-dev:13.0-web_editor-summernote-assets-in-media-dialog-fix-sad branch from f301884 to aaac2e2 Feb 14, 2020
@sdegueldre

This comment has been minimized.

Copy link
Contributor Author

sdegueldre commented Feb 14, 2020

@qsm-odoo done

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 14, 2020
Copy link
Contributor

qsm-odoo left a comment

@robodoo robodoo added the r+ 👌 label Feb 14, 2020
robodoo pushed a commit that referenced this pull request Feb 14, 2020
Due to the infamous web_editor revert, summernote assets files are once
again created and stored in DB, but because they do not contain
'assets_' in their name, they would show up in the media dialog. This
commit fixes that by also adding 'summernote' to the assets domain.o

This also means they would not be regenerated by the debug 'regenerate
assets' feature.

closes #45300

Related: #45298
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 14, 2020

Staging failed: ci/runbot (view more at http://runbot.odoo.com/runbot/build/1245367)

@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Feb 17, 2020

@robodoo retry

@robodoo robodoo removed the error 🙅 label Feb 17, 2020
@robodoo robodoo closed this in 4e1b4c7 Feb 17, 2020
@robodoo robodoo added merged 🎉 and removed merging 👷 labels Feb 17, 2020
@robodoo robodoo deployed to merge Feb 17, 2020 Active
@sdegueldre sdegueldre deleted the odoo-dev:13.0-web_editor-summernote-assets-in-media-dialog-fix-sad branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.