Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[FIX] config: fix pg_dump not found #45354
Issue - Remove ~/.odoorc - Launch a server - Try to dump the db in db manager Ok - Restart the server - Retry pg_dump not found Cause When the .odoorc file is not there, the pg_path option is not present so the normalize method set it to None When the server is restarted, it re-checks the options (which are strings) and in the normalize method we check "if not pg_path" but 'None' is truthy so it thinks this is a real path. Solution Check if not pg_path or if pg_path string is None OPW-2189789
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.