Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[FW][FIX] website_sale_coupon: prevent race condition #45356
2 lasts steps are:
But the last condition was already true before landing to the checkout, thus
The following would happen every time:
The fix simply wait for the checkout page to be loaded as it was supposed to at
Forward-port of odoo/enterprise#8322
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).
In the former case, you may want to edit this PR message as well.
2 lasts steps are: - Click on go to checkout - Ensure checkout total is correct But the last condition was already true before landing to the checkout, thus the last step would succeed while the page is transitionning to the checkout. The following would happen every time: - Click on go to checkout - Last step succeed directly after the previous step click on Go to checkout Then, the following would happen rarely: - The tour is considered successful - The checkout page is loaded - Some GET requests are performed - The tour is killed (cookies & local storage) - Some other GET requests are crashing, such as: `Error loading file http://127.0.0.1:8069/web/webclient/locale/en_US` The fix simply wait for the checkout page to be loaded as it was supposed to at first, before checking the last step. Forward-port of odoo/enterprise#8322 X-original-commit: odoo/enterprise@67686b6 (coupon was moved from enterprise to community in Odoo saas-12.3) Closes #45097