Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] hr_holidays: fix kanban view date format #45360

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Feb 14, 2020

Issue

- Install Time Off & Studio
- Set up your language to English with format date
  to %d/%m/%y instead of %m/%d/%y
- Enable Kanban view in Time Off dashboard with Studio
- Compare Kanban and List view

The list view dates is correctly formatted but not
the kanban view dates

Cause

We use momentjs which doesn't take the user date format
in account, only the locale.

Solution

Use a field with datetime widget which handle this case.

OPW-2195584

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #45267
Forward-Port-Of: #45251

Issue

	- Install Time Off & Studio
	- Set up your language to English with format date
	  to %d/%m/%y instead of %m/%d/%y
	- Enable Kanban view in Time Off dashboard with Studio
	- Compare Kanban and List view

	The list view dates is correctly formatted but not
	the kanban view dates

Cause

	We use momentjs which doesn't take the user date format
	in account, only the locale.

Solution

	Use a field with datetime widget which handle this case.

OPW-2195584

X-original-commit: a7f9e3d
@robodoo robodoo added the seen 🙂 label Feb 14, 2020
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Feb 14, 2020

Ping @jvm-odoo, @nim-odoo
Cherrypicking 3847855 of source #45251 failed

stdout:

On branch saas-13.2-13.0-opw-2195584-fix-timeoff-kanban-date-jvm-8dvD-fw
You are currently cherry-picking commit 3847855dd99.

nothing to commit, working tree clean

stderr:

The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git reset'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@nim-odoo nim-odoo closed this Feb 14, 2020
@robodoo robodoo added the closed 💔 label Feb 14, 2020
@jvm-odoo jvm-odoo deleted the odoo-dev:saas-13.2-13.0-opw-2195584-fix-timeoff-kanban-date-jvm-8dvD-fw branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.