Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] config: fix pg_dump not found #45361

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Feb 14, 2020

Issue

- Remove ~/.odoorc
- Launch a server
- Try to dump the db in db manager

Ok

- Restart the server
- Retry

pg_dump not found

Cause

When the .odoorc file is not there,
the pg_path option is not present so
the normalize method set it to None

When the server is restarted, it re-checks
the options (which are strings) and in the
normalize method we check "if not pg_path"
but 'None' is truthy so it thinks this is
a real path.

Solution

Check if not pg_path or if pg_path string
is None

OPW-2189789

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #45354

Issue

	- Remove ~/.odoorc
	- Launch a server
	- Try to dump the db in db manager

	Ok

	- Restart the server
	- Retry

	pg_dump not found

Cause

	When the .odoorc file is not there,
	the pg_path option is not present so
	the normalize method set it to None

	When the server is restarted, it re-checks
	the options (which are strings) and in the
	normalize method we check "if not pg_path"
	but 'None' is truthy so it thinks this is
	a real path.

Solution

	Check if not pg_path or if pg_path string
	is None

OPW-2189789

X-original-commit: f080964
@robodoo robodoo added the seen 🙂 label Feb 14, 2020
@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Feb 14, 2020

This PR targets saas-13.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot-and-Forwardbot#forward-port

@C3POdoo C3POdoo added the OE label Feb 14, 2020
@robodoo robodoo added the r+ 👌 label Feb 14, 2020
robodoo pushed a commit that referenced this pull request Feb 14, 2020
Issue

	- Remove ~/.odoorc
	- Launch a server
	- Try to dump the db in db manager

	Ok

	- Restart the server
	- Retry

	pg_dump not found

Cause

	When the .odoorc file is not there,
	the pg_path option is not present so
	the normalize method set it to None

	When the server is restarted, it re-checks
	the options (which are strings) and in the
	normalize method we check "if not pg_path"
	but 'None' is truthy so it thinks this is
	a real path.

Solution

	Check if not pg_path or if pg_path string
	is None

OPW-2189789

closes #45361

X-original-commit: f080964
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
@robodoo robodoo closed this Feb 14, 2020
@robodoo robodoo deployed to merge Feb 14, 2020 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.