[FW][FIX] config: fix pg_dump not found #45361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue - Remove ~/.odoorc - Launch a server - Try to dump the db in db manager Ok - Restart the server - Retry pg_dump not found Cause When the .odoorc file is not there, the pg_path option is not present so the normalize method set it to None When the server is restarted, it re-checks the options (which are strings) and in the normalize method we check "if not pg_path" but 'None' is truthy so it thinks this is a real path. Solution Check if not pg_path or if pg_path string is None OPW-2189789 X-original-commit: f080964
|
This PR targets saas-13.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot-and-Forwardbot#forward-port |
robodoo
added
forwardport
robodoo
pushed a commit
that referenced
this pull request
Feb 14, 2020
Issue - Remove ~/.odoorc - Launch a server - Try to dump the db in db manager Ok - Restart the server - Retry pg_dump not found Cause When the .odoorc file is not there, the pg_path option is not present so the normalize method set it to None When the server is restarted, it re-checks the options (which are strings) and in the normalize method we check "if not pg_path" but 'None' is truthy so it thinks this is a real path. Solution Check if not pg_path or if pg_path string is None OPW-2189789 closes #45361 X-original-commit: f080964 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
fw-bot
deleted the
saas-13.1-13.0-opw-2189789-fix-pg-dump-not-found-jvm-_L7k-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cause
Solution
OPW-2189789
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #45354