Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web_editor: fix buttons position for bg-position when parallax #48356

Closed

Conversation

@bvr-odoo
Copy link
Contributor

bvr-odoo commented Mar 25, 2020

correction of the position of the buttons when editing bg-image
position with a parallax effect other than "fixed".

Task-46147

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Copy link
Contributor

qsm-odoo left a comment

@bvr-odoo This PR does not work at all... :/ Could you retry?

@bvr-odoo bvr-odoo force-pushed the odoo-dev:saas-13.2-fix-buttons-position-bvr branch from 24e4d07 to af3eb80 Mar 25, 2020
@robodoo robodoo removed the CI 🤖 label Mar 25, 2020
@bvr-odoo

This comment has been minimized.

Copy link
Contributor Author

bvr-odoo commented Mar 25, 2020

@bvr-odoo This PR does not work at all... :/ Could you retry?

oops. I forgot to add the class on the buttons. It's ok now ;)

@robodoo robodoo added the CI 🤖 label Mar 25, 2020
Correction of the position of the buttons when editing bg-image
position with a parallax effect other than "fixed".

task-46147
@qsm-odoo qsm-odoo force-pushed the odoo-dev:saas-13.2-fix-buttons-position-bvr branch from af3eb80 to 1a26b79 Mar 26, 2020
@robodoo robodoo removed the CI 🤖 label Mar 26, 2020
Copy link
Contributor

qsm-odoo left a comment

robodoo pushed a commit that referenced this pull request Mar 26, 2020
Correction of the position of the buttons when editing bg-image
position with a parallax effect other than "fixed".

task-46147

closes #48356

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo robodoo closed this Mar 26, 2020
@robodoo robodoo deployed to merge Mar 26, 2020 Active
@qsm-odoo qsm-odoo deleted the odoo-dev:saas-13.2-fix-buttons-position-bvr branch Mar 26, 2020
@qsm-odoo

This comment has been minimized.

Copy link
Contributor

qsm-odoo commented Mar 26, 2020

@d-fence fw-bot created two PR for master here... (I closed the first one which was not even marked as a forward-port one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.