Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] web: mobile quick search view issues #48376

Conversation

@fw-bot
Copy link
Contributor

fw-bot commented Mar 25, 2020

Steps to reproduce:

  1. Open sales on mobile

  2. Click on the search icon (with breadcrumb)

    Issue #1:
    The displayed cross on the right suggests to users that it's
    used to close the facets but it's not.
    We replace it by a back arrow to close the search like in other
    apps.

  3. Click on create 'Create'

  4. Select a customer (Without breadcrumb)

    Issue #2:
    We don't have any breadcrumb inside the control_panel,
    so we should always display the search. There is no
    need to open/close it.

Task ID: 2200099

Forward-Port-Of: #46086

@fw-bot

This comment has been minimized.

Copy link
Contributor Author

fw-bot commented Mar 25, 2020

Ping @res-odoo, @adr-odoo
Cherrypicking 8f6c2b5 of source #46086 failed

stderr:

error: could not apply 8f6c2b5f561... [FIX] web: mobile quick search view issues
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@C3POdoo C3POdoo added the RD label Mar 25, 2020
@res-odoo res-odoo force-pushed the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch from 5d18cd8 to 93ba182 Mar 26, 2020
@res-odoo res-odoo requested a review from adr-odoo Mar 26, 2020
@res-odoo res-odoo self-assigned this Mar 26, 2020
@robodoo robodoo added the CI 🤖 label Mar 26, 2020
@res-odoo res-odoo force-pushed the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch from 93ba182 to fb63c33 Mar 26, 2020
@robodoo robodoo removed the CI 🤖 label Mar 26, 2020
@res-odoo res-odoo force-pushed the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch from fb63c33 to 3fb7641 Mar 26, 2020
@robodoo robodoo added the CI 🤖 label Mar 26, 2020
@res-odoo res-odoo force-pushed the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch from 3fb7641 to 90cfba0 Mar 27, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 27, 2020
Now we have the mobile search_panel in enterprise,
this commit simply adapt the Odoo repos part with:

- Css Clean up
- Remove the no longer existing step inside the tour
the button 'o_enable_searchview' no longer exist
inside a M2X dialog

Task ID: 2200099
@pparidans pparidans force-pushed the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch from 90cfba0 to 74d9141 Mar 29, 2020
@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Mar 29, 2020
@pparidans

This comment has been minimized.

Copy link
Contributor

pparidans commented Mar 29, 2020

@pparidans pparidans self-requested a review Mar 29, 2020
@robodoo robodoo added the r+ 👌 label Mar 29, 2020
robodoo pushed a commit that referenced this pull request Mar 29, 2020
Now we have the mobile search_panel in enterprise,
this commit simply adapt the Odoo repos part with:

- Css Clean up
- Remove the no longer existing step inside the tour
the button 'o_enable_searchview' no longer exist
inside a M2X dialog

Task ID: 2200099

closes #48376

Related: odoo/enterprise#9494
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
@robodoo robodoo closed this Mar 29, 2020
@robodoo robodoo deployed to merge Mar 29, 2020 Active
@pparidans pparidans deleted the odoo-dev:master-13.0-mobile-search-filter-fix-res-aMrK-fw branch Mar 29, 2020
vtu-odoo added a commit to odoo-dev/odoo that referenced this pull request Mar 30, 2020
Now we have the mobile search_panel in enterprise,
this commit simply adapt the Odoo repos part with:

- Css Clean up
- Remove the no longer existing step inside the tour
the button 'o_enable_searchview' no longer exist
inside a M2X dialog

Task ID: 2200099

closes odoo#48376

Related: odoo/enterprise#9494
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.