Fetchmail breaks cron transaction policy #585
Conversation
Fetchmail module installs a method to process mail messages from incoming mail servers. This method is called by ir.cron periodically. ir.cron uses a db locking strategy on cron job record to prevent simoultaneous call by multiple workers threads on the same job. Fetchmail cron method receives the cursor from cron and reuses it making a cr.commit on each received message, thus breaking the lock policy of to prevent simoultaneous execution. The net effect is that fetchmail is called several times when message collecting from input mail servers takes longer than the interval between cron calls (60 seconds)(a common situation when the server is configured with slow mail services). In my cases this process ends up with stalled cron fetchamail process, and thus NO MAIL WAS COLLECTED unless you manually reset the server The solution is to use a separate cursor to process incoming messages See https://bugs.launchpad.net/openobject-addons/+bug/1228421
|
Hello, Have you been able to reproduce that bug ? It seems to me it's not present as we are using two different cursors for locking and running the job. An easy way to prove it is using the applying the following patch. It will commit between each mail fetched by your imap server. Even during the sleep you can not edit your cron (e.g. change the date) and check that only one cron is running (if you set a 1min running frequency). It is still locked. |
|
I can confirm I'm using the same ir_cron.py as in odoo's 7.0 branch. The fetchmail server got stalled twice in a month, causing a downtime in email processing until we notice it and restart the server. I still have to run with my patch applied in production to confirm if it still happens. |
ghost
assigned 
|
Confirming @mart-e thoughts. Are you sure it is due to the cursor ? Note there was some patches recently in the cron, are you using the latest 7.0 sources ? |
|
If there were concurrency issues, they were fixed in 7.0 at revision 6788edc (backport of master). |
|
I have similar issue #7464 |
[ADD] account_voucher migration. All checks passed. Merging.
Fetchmail module installs a method to process mail messages from incoming mail servers.
This method is called by ir.cron periodically. ir.cron uses a db locking strategy on cron job record to prevent simoultaneous call by multiple workers threads on the same job.
Fetchmail cron method receives the cursor from cron and reuses it making a cr.commit on each received message, thus breaking the lock policy of to prevent simoultaneous execution. The net effect is that fetchmail is called several times when message collecting from input mail servers takes longer than the interval between cron calls (60 seconds)(a common situation when the server is configured with slow mail services). In my cases this process ends up with stalled cron fetchamail process, and thus NO MAIL WAS COLLECTED unless you manually reset the server
The solution is to use a separate cursor to process incoming messages
See https://bugs.launchpad.net/openobject-addons/+bug/1228421