Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] mail, *: clean up message component by introducing view model #76718

Closed

Conversation

seb-odoo
Copy link
Contributor

@seb-odoo seb-odoo commented Sep 16, 2021

  • = hr, hr_holidays, sms, snailmail, website_livechat

Message model incorrectly contained data related to a specific component (only
one) even though there can be multiple message components per message model.

This cascaded to adapting related component/models to the same principle.

@seb-odoo seb-odoo added the Discuss Discuss, mail, chatter, livechat, attachments label Sep 16, 2021
@seb-odoo seb-odoo self-assigned this Sep 16, 2021
@robodoo
Copy link
Contributor

robodoo commented Sep 16, 2021

@C3POdoo C3POdoo requested a review from a team September 16, 2021 20:02
@seb-odoo seb-odoo force-pushed the saas-14.5-message-view-model-seb branch from d82a19a to a032675 Compare September 16, 2021 20:14
@C3POdoo C3POdoo added the RD research & development, internal work label Sep 16, 2021
@seb-odoo seb-odoo force-pushed the saas-14.5-message-view-model-seb branch 7 times, most recently from 7ec6fa1 to 35c71bd Compare September 16, 2021 23:09
@seb-odoo seb-odoo marked this pull request as draft September 17, 2021 14:43
@seb-odoo seb-odoo force-pushed the saas-14.5-message-view-model-seb branch 7 times, most recently from 081a96b to 4f90691 Compare September 25, 2021 02:01
@seb-odoo seb-odoo force-pushed the saas-14.5-message-view-model-seb branch 3 times, most recently from a251975 to 9eca008 Compare October 1, 2021 14:04
@seb-odoo
Copy link
Contributor Author

seb-odoo commented Oct 4, 2021

Hello @odoo/rd-security could you please validate this change?

Reason: there is a rename on the flagged line

Side question: shouldn't we be able to do it ourselves for trivial cases?

@seb-odoo seb-odoo force-pushed the saas-14.5-message-view-model-seb branch 4 times, most recently from f652590 to 1fb39fa Compare October 4, 2021 10:26
@mart-e
Copy link
Contributor

mart-e commented Oct 5, 2021

Side question: shouldn't we be able to do it ourselves for trivial cases?

I don't mind if we give more people have the override rights but there is no such things as a trivial case (well maybe writting innerHTML in a code comment is a trivial case).
For instance, here, the renaming of an existing variable is not a valid enough reason for override. It's an occasion for a double check and ensure the content is still trust-worthy and not injectable (e.g. if we modified the computation of prettyBody in the meantime and make it unsafe by accident).

robodoo pushed a commit that referenced this pull request Oct 5, 2021
* = hr, hr_holidays, sms, snailmail, website_livechat

Message model incorrectly contained data related to a specific component (only
one) even though there can be multiple message components per message model.

This cascaded to adapting related component/models to the same principle.

closes #76718

closes #77779

Related: odoo/enterprise#20964
Related: odoo/enterprise#21426
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
@fw-bot fw-bot deleted the saas-14.5-message-view-model-seb branch October 18, 2021 22:46
seb-odoo added a commit to odoo-dev/odoo that referenced this pull request Jun 10, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739
robodoo pushed a commit that referenced this pull request Jun 10, 2022
Trigger up o-message-posted was inadvertently removed in #76718

task-2880739

closes #93282

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jun 10, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739

X-original-commit: d03df56
robodoo pushed a commit that referenced this pull request Jun 10, 2022
Trigger up o-message-posted was inadvertently removed in #76718

task-2880739

closes #93352

X-original-commit: d03df56
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
seb-odoo added a commit to odoo-dev/odoo that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739

X-original-commit: d03df56
robodoo pushed a commit that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in #76718

task-2880739

closes #93357

X-original-commit: d03df56
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739

X-original-commit: 2997fa8
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739

X-original-commit: 2997fa8
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in odoo#76718

task-2880739

X-original-commit: 2997fa8
robodoo pushed a commit that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in #76718

task-2880739

closes #93421

X-original-commit: 2997fa8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
robodoo pushed a commit that referenced this pull request Jun 13, 2022
Trigger up o-message-posted was inadvertently removed in #76718

task-2880739

closes #93432

X-original-commit: 2997fa8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss Discuss, mail, chatter, livechat, attachments RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants