[IMP] stock: Warning on Replenishing too much #97802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
from
4a406e2
to
1aed730
Compare
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
3 times, most recently
from
14c5192
to
1dc24d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
amoyaux
reviewed
Oct 27, 2022
amoyaux
reviewed
Oct 27, 2022
amoyaux
reviewed
Oct 27, 2022
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
amoyaux
reviewed
Oct 27, 2022
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
4 times, most recently
from
d5ef169
to
629e645
Compare
mama-odoo
changed the title
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
5 times, most recently
from
cabdb81
to
4d1746d
Compare
amoyaux
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
from
4d1746d
to
a2b3280
Compare
amoyaux
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
from
a2b3280
to
b114a7f
Compare
amoyaux
reviewed
Nov 29, 2022
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
from
9a3cff6
to
304d131
Compare
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
4 times, most recently
from
68e4f67
to
8001b08
Compare
mama-odoo
changed the title
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
2 times, most recently
from
655bf57
to
2fd302c
Compare
clesgow
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Overall looks good to me. Still added a few nitpicks here and there, but nothing big.
You might want to update the PR message, since it doesn't seem to match the changes in the spec 😉
And while you're at it, you should mention the task in the PR & more importantly the commit
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
addons/sale_purchase_stock/tests/test_unwanted_replenish_flow.py
Outdated
Show resolved
Hide resolved
**Steps to reproduce :** - Create a Product A, with no stock and a 0 min 1 max manual reordering rule (no sales lead time, no purchase lead time) - Sell 10 of A with a delivery scheduled today - In Replenishment, create a PO for A, confirm it with reception scheduled today - Reschedule reception of PO in 7 days **Expected Behavior :** The forecast icon is replaced by an orange warning icon. When hovering the icon, the user is warned that replenishing can lead to an overstock. **Current behavior :** In Replenishment, Product A has a forecast of -10 and Qty to Order is set to 11. When the user replenish A again, the PO is created and may lead to an overstock. task : 2918947
mama-odoo
force-pushed
the
master-stock-warn_unwanted_replenish-mama
branch
from
560f2d6
to
ae62f97
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 21, 2023
**Steps to reproduce :** - Create a Product A, with no stock and a 0 min 1 max manual reordering rule (no sales lead time, no purchase lead time) - Sell 10 of A with a delivery scheduled today - In Replenishment, create a PO for A, confirm it with reception scheduled today - Reschedule reception of PO in 7 days **Expected Behavior :** The forecast icon is replaced by an orange warning icon. When hovering the icon, the user is warned that replenishing can lead to an overstock. **Current behavior :** In Replenishment, Product A has a forecast of -10 and Qty to Order is set to 11. When the user replenish A again, the PO is created and may lead to an overstock. task : 2918947 closes #97802 Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce :
Expected Behavior :
The forecast icon is replaced by an orange warning icon.
When hovering the icon, the user is warned that replenishing can lead to an overstock.
Current behavior :
In Replenishment, Product A has a forecast of -10 and Qty to Order is set to 11.
When the user replenish A again, the PO is created and may lead to an overstock.
task : 2918947