Skip to content

[FIX] util/fields: check new table first #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[FIX] util/fields: check new table first #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/util/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,17 +1223,7 @@ def change_field_selection_values(cr, model, field, mapping, skip_inherit=()):
[model, field, [k for k in mapping if k not in mapping.values()]],
)

if table_exists(cr, "ir_values"):
query = """
UPDATE ir_values
SET value = %(json)s::jsonb->>value
WHERE model = %(model)s
AND name = %(name)s
AND key = 'default'
AND value IN %(keys)s
"""
dumped_map = {pickle.dumps(k): pickle.dumps(v) for k, v in mapping.items()}
else:
if table_exists(cr, "ir_default"):
query = """
UPDATE ir_default d
SET json_value = (%(json)s::jsonb->>d.json_value)
Expand All @@ -1244,6 +1234,17 @@ def change_field_selection_values(cr, model, field, mapping, skip_inherit=()):
AND d.json_value IN %(keys)s
"""
dumped_map = {json.dumps(k): json.dumps(v) for k, v in mapping.items()}
else:
query = """
UPDATE ir_values
SET value = %(json)s::jsonb->>value
WHERE model = %(model)s
AND name = %(name)s
AND key = 'default'
AND value IN %(keys)s
"""
dumped_map = {pickle.dumps(k): pickle.dumps(v) for k, v in mapping.items()}

data = {
"keys": tuple(dumped_map),
"json": json.dumps(dumped_map),
Expand Down