-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Draft) [ui-chassis-spring] remove zuul dependencies #4710
Conversation
Signed-off-by: Bogdan Sava <bogdan.sava@gmail.com>
Signed-off-by: Bogdan Sava <bogdan.sava@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with removing zuul.
If this is merged, what is the impact on the current docs for running the UI
Also what is the effect on the current container environment (labs & simple). Has it been tested?
I think we need to confirm both before merging, especially as our next release is imminent
Moving forward with #4549 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes the requirement for zuul - however without zuul the current approach of launching the UI will no longer be the same. If this changes function we either need to ensure each PR is an incremental update without breakage, or we combine them together in a single PR?
Or is the intent that we do #4723 first ?
If they need to be done together, Taking the commit's and cherrypicking may be the easiest approach
We also need to add documentation, as removal of zuul affects how a user would deploy the UI if they are setting up themselves. |
This PR is incomplete, check this one for the complete removal of Zuul Module: #4922 |
No description provided.