Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Draft) [ui-chassis-spring] remove zuul dependencies #4710

Closed
wants to merge 5 commits into from

Conversation

bogdan-sava
Copy link
Contributor

No description provided.

Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with removing zuul.
If this is merged, what is the impact on the current docs for running the UI
Also what is the effect on the current container environment (labs & simple). Has it been tested?
I think we need to confirm both before merging, especially as our next release is imminent

@lpalashevski
Copy link
Contributor

lpalashevski commented Feb 23, 2021

Moving forward with #4549

Copy link
Member

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the requirement for zuul - however without zuul the current approach of launching the UI will no longer be the same. If this changes function we either need to ensure each PR is an incremental update without breakage, or we combine them together in a single PR?

Or is the intent that we do #4723 first ?

If they need to be done together, Taking the commit's and cherrypicking may be the easiest approach

@planetf1
Copy link
Member

planetf1 commented Mar 4, 2021

We also need to add documentation, as removal of zuul affects how a user would deploy the UI if they are setting up themselves.

@planetf1 planetf1 marked this pull request as draft March 4, 2021 14:10
@planetf1 planetf1 changed the title [ui-chassis-spring] remove zuul dependencies (Draft) [ui-chassis-spring] remove zuul dependencies Mar 4, 2021
@sarbull
Copy link
Member

sarbull commented Mar 18, 2021

This PR is incomplete, check this one for the complete removal of Zuul Module: #4922

@sarbull sarbull closed this Mar 18, 2021
@bogdan-sava bogdan-sava deleted the refactoring branch March 23, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants