New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demandlib error in creation of h array used in the BDEW heatprofile method #129

Closed
birgits opened this Issue Apr 6, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@birgits
Copy link
Member

birgits commented Apr 6, 2016

The following line should be changed from

h = np.array(SF_mat)[np.array(range(0, 8760))[:], (get_temperature_interval(df) - 1)[:]]

to

h = np.array(SF_mat)[np.array(range(0, 8760))[:], (get_temperature_interval(df) + 2)[:]]

since the temp_intervall columns in the SF_mat array don't start in column 0 but in column 3.
I created a bugfix branch bugfix/bdew_heatprofile where I implemented that change.
@simnh: What do you think?

@birgits birgits added this to the April 2016 release milestone Apr 6, 2016

@Simn

This comment has been minimized.

Copy link

Simn commented Apr 6, 2016

You got the wrong guy, but hi anyway!

@simnh

This comment has been minimized.

Copy link
Member

simnh commented Apr 8, 2016

I am not really into that functionality, so I you think it's correct feel free to merge (if functionalities still work)

@birgits

This comment has been minimized.

Copy link
Member Author

birgits commented Apr 8, 2016

Testing the bugfix with a commercial type produced another error so I now fixed it by dropping unnecessary columns from the SF_mat dataframe. Also, since there is no parameter building_class for commercial types I changed it to be a keyword argument with the default value 0, since building_class for commercial types was set to 0 in the shlp_hour_factors.csv.
The changes passed the validation with the heat_demand_example.py for all residential and commercial types so I will push it to the dev.

@birgits birgits closed this Apr 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment