Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updemandlib error in creation of h array used in the BDEW heatprofile method #129
Comments
birgits
added
bug
feedback wanted
labels
Apr 6, 2016
birgits
added this to the April 2016 release milestone
Apr 6, 2016
This comment has been minimized.
This comment has been minimized.
Simn
commented
Apr 6, 2016
You got the wrong guy, but hi anyway! |
uvchik
assigned
simnh
Apr 7, 2016
This comment has been minimized.
This comment has been minimized.
I am not really into that functionality, so I you think it's correct feel free to merge (if functionalities still work) |
This comment has been minimized.
This comment has been minimized.
Testing the bugfix with a commercial type produced another error so I now fixed it by dropping unnecessary columns from the SF_mat dataframe. Also, since there is no parameter building_class for commercial types I changed it to be a keyword argument with the default value 0, since building_class for commercial types was set to 0 in the shlp_hour_factors.csv. |
birgits commentedApr 6, 2016
The following line should be changed from
h = np.array(SF_mat)[np.array(range(0, 8760))[:], (get_temperature_interval(df) - 1)[:]]
to
h = np.array(SF_mat)[np.array(range(0, 8760))[:], (get_temperature_interval(df) + 2)[:]]
since the temp_intervall columns in the SF_mat array don't start in column 0 but in column 3.
I created a bugfix branch bugfix/bdew_heatprofile where I implemented that change.
@simnh: What do you think?