New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the PostHeating class and its solph functions #116

Merged
merged 8 commits into from Mar 24, 2016

Conversation

Projects
None yet
2 participants
@uvchik
Copy link
Member

uvchik commented Mar 8, 2016

The PostHeating class was created to describe a instantaneous flow heater. The new idea is describe a more generic class that describes a general transformer that has two inputs and one output.
This transformer can represent a heat pump, an instant flow heater or any other component with two inputs and one output.

See issue #114 for more information

Refactor the PostHeating class and its solph functions
The PostHeating class was created to describe a instantaneous
flow heater. The new idea is describe a more generic class that
describes a general transformer that has two inputs and one output.
This transformer can represent a heat pump, an instant flow heater
or any other component with two inputs and one output.
change PostHeating class to a more generic TwoInputsOneOutput class
TwoInputsOneOutput is the working name and might be changed later.

@uvchik uvchik added the enhancement label Mar 8, 2016

@uvchik uvchik self-assigned this Mar 8, 2016

@uvchik uvchik added this to the March 2016 release milestone Mar 8, 2016

@uvchik

This comment has been minimized.

Copy link
Member Author

uvchik commented Mar 10, 2016

Now there are two ways to create a heat pump. One can use this TwoInputOneOutput transformer and create a bus representing the low temperature reservoir or one can use a simple transformer and pass an eta-array representing the COP.

I think it is more common to use the simple transformer so I will commit a proposal to use array-like efficiency values for simple transformer.

@uvchik

This comment has been minimized.

Copy link
Member Author

uvchik commented Mar 10, 2016

Commit 897e4be works for me. I do not if it is pythonic to use try...except but it works for lists, numpy.arrays, pandas.Series, tuples and other array-like types.

@simonhilpert, @birgits: What do you think?

@uvchik

This comment has been minimized.

Copy link
Member Author

uvchik commented Mar 10, 2016

If it is okay for you I would adapt the docstrings and merge. All tests are okay, all examples work as expected.

I think commit 897e4be touches all transformers, so if you think we should discuss this in a larger group I would merge this branch without commit 897e4be and start an extra issue.

@birgits

This comment has been minimized.

Copy link
Member

birgits commented Mar 14, 2016

I think it is fine this way as it probably barely adds time to creating the problem but adds great flexibility!

@uvchik uvchik merged commit 427b53f into dev Mar 24, 2016

@uvchik uvchik deleted the features/two_inputs_one_output_transformer branch Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment