Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Revision/expanding sequences Sequences with default value get not expanded #438
This revision aims to reduce unnecessary list extensions while creating the model - see related issue #436.
Related issue: #436
I think these changes are good, improving oemof solph! What do you think?
That's strange because the test has been done: https://travis-ci.org/oemof/oemof/builds/329396739
The test failed by the way :-P
The last visible test is 7 days ago. I have no idea.
Bit confused @simnh : Is your request still open, or did you change your mind and approved?
I don't really see the advantage of creating a variable length list, if
Sorry, i did not check for the docstring tests (I will change my testing parameters to take these into account for the future). The test fails, because no iterable list is created internally.
So, there is an decision to make, if this behaviour is wanted or not. Personally, I prefer my implementation as oemof is set up faster and I don't see the point in creating a list of 8760 times the same value...
I already approved this one, as I changed my mind ;-)
the module is not located on the core level but in the solph package...because you said above 'this will improve oemof core'