Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded energysystem compatibility for param_results #445
Conversation
henhuy
added
the
enhancement
label
Feb 2, 2018
henhuy
self-assigned this
Feb 2, 2018
henhuy
requested review from
uvchik
and
ckaldemeyer
Feb 2, 2018
This comment has been minimized.
This comment has been minimized.
It's only a simple feature - I did not know if I can push directly to dev... |
ckaldemeyer
reviewed
Feb 5, 2018
Parameters | ||
---------- | ||
system: Model or energysystem |
This comment has been minimized.
This comment has been minimized.
ckaldemeyer
Feb 5, 2018
Member
I would suggest "Model or EnergySystem" or "optimization model or energy system"
ckaldemeyer
approved these changes
Feb 5, 2018
If the docstring is changed, I am fine. Thanks! |
This comment has been minimized.
This comment has been minimized.
I would say By the way I would not allow passing a model but only(!) |
This comment has been minimized.
This comment has been minimized.
I thought I shouldn't change the API after a release? |
This comment has been minimized.
This comment has been minimized.
Ah okay, I did not know that this is already part of v0.2.0, I thought this is something new. Anyhow, we should talk about the usage of Models and Systems on the next developer meeting. |
henhuy commentedFeb 2, 2018
Just a little addition to former add-node-param-obj-results PR:
Now, not only (Operational-)Model, but also the energysystem can be
given as input parameter for processing.param_results function