New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console test and clean installation test #453

Merged
merged 5 commits into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@uvchik
Copy link
Member

uvchik commented Mar 9, 2018

  • Describe your pull request as transparent as possible
    • Clean code according to developer rules
    • Console script added to test oemof including all nosetests and doctests. I did not add anything to the documentation because I think we can test how it works and if it works fine I will add a line there.
    • Just use test_oemof within your virtual environment.
    • I think it should be added it to the v0.2.1 release, because it is mostly code-clean-up and a new hidden function that could be removed in the next release if it does not work as intended. No risk in my opinion 馃槃

@uvchik uvchik added the enhancement label Mar 9, 2018

@uvchik uvchik added this to the v0.2.1 milestone Mar 9, 2018

@jnnr

This comment has been minimized.

Copy link
Contributor

jnnr commented Mar 9, 2018

Looks good. Thanks!

@jnnr jnnr merged commit b03a86a into dev Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jnnr jnnr deleted the add_console_test_and_clean_installation_test branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment