Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tuple as label causes problems #507

Merged
merged 8 commits into from Jul 17, 2018

Conversation

@uvchik
Copy link
Member

commented Jul 3, 2018

If we use tuples as labels as it was originally intended but never used some errors occur.

I fixed some of these bugs and adapted some tests.

  • ExtractionTurbineCHP now uses objects instead of labels
  • The graph module uses the string of the label instead of the label (str(n.label) instead of n.label)
  • in the detect_scalars_and_sequences function the label is filtered to be not detected as sequence if the label is a tuple.

I want to merge them soon.

@uvchik uvchik added the bug label Jul 3, 2018

@uvchik uvchik added this to the v0.2.3 milestone Jul 3, 2018

@uvchik uvchik self-assigned this Jul 3, 2018

@uvchik uvchik requested review from gnn and simnh Jul 3, 2018

uvchik added some commits Jul 3, 2018

@uvchik uvchik added the urgent label Jul 9, 2018

@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2018

Coverage Status

Coverage increased (+0.2%) to 81.327% when pulling 643459b on fix/tuple_as_label_causes_problems into 76fcfa6 on dev.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Jul 9, 2018

Coverage Status

Coverage increased (+0.2%) to 81.327% when pulling 643459b on fix/tuple_as_label_causes_problems into 76fcfa6 on dev.

@uvchik

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2018

Any objections here. It effects my app and it would help to merge it soon.

@uvchik

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2018

No objections, tests fine, coverall fine... I will merge 😄

@uvchik uvchik merged commit c79a289 into dev Jul 17, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@uvchik uvchik deleted the fix/tuple_as_label_causes_problems branch Jul 17, 2018

@uvchik uvchik modified the milestones: v0.2.3, v0.3.0 Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.