Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and/or example with one time step #519

Merged
merged 7 commits into from Jan 14, 2019

Conversation

@uvchik
Copy link
Member

commented Sep 6, 2018

Due to a pyomo error it was not possible to model one time step but this issue seems to be fixed recently. We should add tests to make sure that it keeps working.

  • Related to #306

  • Share your knowledge:
    In the past there was a pyomo error message which we could not be solve but this message is gone and a test with a simple example was successful.

  • Add to whatsnew, it was announced as known issue, so we should announce if it is solved

  • Add a tests

  • Add an example

  • Check documentation

Add test and/or example with one time step for example with an outer
Due to a pyomo problem it was not possible to model one time step but
this issue seems to be fixed recently. We should add tests to make sure
that it keeps working.

@uvchik uvchik self-assigned this Sep 6, 2018

@uvchik uvchik requested a review from ckaldemeyer Sep 6, 2018

@uvchik uvchik added this to the v0.3.0 milestone Sep 6, 2018

@coveralls

This comment has been minimized.

Copy link

commented Sep 6, 2018

Coverage Status

Coverage remained the same at 86.928% when pulling f9c668b on features/model_one_time_step into 14a6068 on dev.

@uvchik uvchik changed the title Add test and/or example with one time step for example with an outer Add test and/or example with one time step Sep 18, 2018

@uvchik uvchik added this to To do in Release of v0.3.0 via automation Dec 11, 2018

@uvchik uvchik removed the request for review from ckaldemeyer Dec 11, 2018

@uvchik uvchik changed the base branch from dev to releases/v0_3_0 Dec 11, 2018

@uvchik

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

I added a test with one time step, I checked the documentation and could not find anything about the minimum number of time steps. There is an old whatsnew entry that says that it is not possible but the actual whatsnew will make clear that it is now possible. I do not think that I will add an example at the moment. This can be done by users/developers who use this feature in time step model or any kind of outer loop.

For me this is ready to merge.

@jnnr Please review.

@uvchik uvchik requested a review from jnnr Dec 11, 2018

@uvchik

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

Sorry the test has interfered with the previous tests, so I had to explicit switch off the auto-registration.

@uvchik uvchik merged commit 5bcb7d7 into releases/v0_3_0 Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on features/model_one_time_step at 88.038%
Details

Release of v0.3.0 automation moved this from To do to Done Jan 14, 2019

@uvchik uvchik deleted the features/model_one_time_step branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.