New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor events #101

Merged
merged 24 commits into from Dec 5, 2018

Conversation

1 participant
@oestrich
Copy link
Owner

oestrich commented Nov 30, 2018

Starting on a new set of event modules for a more conformed parsing of events.

  • Each event is its own module
  • Each action is its own module
  • Parse and validate options, being less strict about validating them

See this gist for other plans.

  • parse separate event types
  • parse event options
  • parse actions
  • limit actions based on the event type
  • update documentation
  • fill in all of the existing events
  • admin should still display old invalid events and let you edit them into the new version
    • store a simple map for events
    • parse the events on NPC process boot
  • use the new event structure
    • split out events
    • split out actions
    • calculate the delay required for ticking events
    • invalid parsed events are skipped
    • delete most of the old NPC event code
  • delete old event parsing

@oestrich oestrich self-assigned this Nov 30, 2018

Start new events set of modules
- Each event is its own module
- Each action is its own module
- Parse and validate options, being less strict about validating them

@oestrich oestrich force-pushed the events-refactor branch from 64eb026 to 82cc0bc Nov 30, 2018

@oestrich oestrich merged commit d05f084 into master Dec 5, 2018

@oestrich oestrich deleted the events-refactor branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment