Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format string is not checked #396

Closed
yarda opened this issue Jun 3, 2013 · 2 comments

Comments

@yarda
Copy link
Contributor

commented Jun 3, 2013

The probblem:

$ python -c "import rrdtool
rrdtool.graph('/tmp/out.png','-f','%n%n')"
Aborted (core dumped)

There is Red Hat bugzilla about it:
http://bugzilla.redhat.com/show_bug.cgi?id=969296

My opinion was that misusing the API is not a bug, but the following probably is:

$ rrdtool graph /tmp/out.png -f '%n%n'
*** %n in writable segment detected ***
Aborted (core dumped)

IMHO the patch for the both issues shouldn't cost much, I proposed simple fix:
http://bugzilla.redhat.com/attachment.cgi?id=756318&action=diff

What is your opinion?

@oetiker

This comment has been minimized.

Copy link
Owner

commented Jun 3, 2013

fair enough ... can you make a pull request ?

@yarda

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2013

No problem.
#397

@yarda yarda closed this Jun 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.