-
Notifications
You must be signed in to change notification settings - Fork 5
Initial look at reducing size of then stack. #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by keeping then function at top, and appending further then functions to the end. Costs a little more in adding then function, but should reduce a lot more in execution (and GC)
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
============================================
- Coverage 81.62% 81.58% -0.05%
+ Complexity 12412 12411 -1
============================================
Files 1279 1279
Lines 55787 55815 +28
Branches 7087 7091 +4
============================================
- Hits 45535 45534 -1
- Misses 8215 8247 +32
+ Partials 2037 2034 -3 Continue to review full report at Codecov.
|
Plus fixing further tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by keeping then function at top, and appending further then
functions to the end. Costs a little more in adding then function, but
should reduce a lot more in execution (and GC)