Skip to content

Initial look at reducing size of then stack. #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 5, 2021

Conversation

sagenschneider
Copy link
Collaborator

This is done by keeping then function at top, and appending further then
functions to the end. Costs a little more in adding then function, but
should reduce a lot more in execution (and GC)

This is done by keeping then function at top, and appending further then
functions to the end.  Costs a little more in adding then function, but
should reduce a lot more in execution (and GC)
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #812 (83265ba) into master (10d704e) will decrease coverage by 0.04%.
The diff coverage is 78.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #812      +/-   ##
============================================
- Coverage     81.62%   81.58%   -0.05%     
+ Complexity    12412    12411       -1     
============================================
  Files          1279     1279              
  Lines         55787    55815      +28     
  Branches       7087     7091       +4     
============================================
- Hits          45535    45534       -1     
- Misses         8215     8247      +32     
+ Partials       2037     2034       -3     
Impacted Files Coverage Δ Complexity Δ
.../net/officefloor/frame/test/TestManagedObject.java 92.18% <ø> (ø) 11.00 <0.00> (ø)
...et/officefloor/frame/test/OfficeFrameTestCase.java 33.79% <50.00%> (ø) 22.00 <0.00> (ø)
...t/officefloor/frame/test/CompleteFlowCallback.java 75.00% <63.63%> (-12.50%) 6.00 <1.00> (+1.00) ⬇️
...et/officefloor/frame/test/ThreadedTestSupport.java 71.26% <69.23%> (-0.54%) 17.00 <5.00> (+3.00) ⬇️
...oor/frame/impl/execute/thread/ThreadStateImpl.java 80.41% <76.23%> (-3.09%) 61.00 <5.00> (+2.00) ⬇️
...floor/frame/impl/execute/job/FunctionLoopImpl.java 88.29% <88.88%> (+3.81%) 15.00 <1.00> (ø)
...ficefloor/frame/test/OfficeManagerTestSupport.java 90.90% <90.90%> (-2.85%) 7.00 <4.00> (+2.00) ⬇️
...frame/impl/execute/executive/DefaultExecutive.java 86.11% <100.00%> (ø) 13.00 <0.00> (ø)
...xecute/function/AbstractDelegateFunctionState.java 63.63% <100.00%> (-7.80%) 5.00 <3.00> (ø)
...xecute/managedobject/ManagedObjectCleanupImpl.java 93.61% <100.00%> (-1.22%) 4.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f907fc...83265ba. Read the comment docs.

@sagenschneider sagenschneider merged commit 70bf614 into master Jan 5, 2021
@sagenschneider sagenschneider deleted the reduce_then_depth branch January 5, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant