Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late move reduction, captures and CUT nodes #2273

Closed

Conversation

Vizvezdenec
Copy link
Contributor

Passed STC
http://tests.stockfishchess.org/tests/view/5d5b2f8e0ebc5925cf1111b8
LLR: 2.96 (-2.94,2.94) [0.50,4.50]
Total: 36026 W: 8122 L: 7779 D: 20125
Passed LTC
http://tests.stockfishchess.org/tests/view/5d5b40c80ebc5925cf111353
LLR: 3.22 (-2.94,2.94) [0.00,3.50]
Total: 133502 W: 22508 L: 21943 D: 89051
Expand of sg's original idea
bench 4192814

bench 4192814
@snicolet
Copy link
Member

Approved, congrats.

@Vizvezdenec, and everybody
It would be nice (in the sense that it would help my job to merge) if your commits in the pull requests were cleaner, with full title (instead of just "tweeg"), full message info to explain the the idea, full test info, etc.

Not only in the web pull request interface, but also in the commit message.

See the wiki for advices: https://github.com/glinscott/fishtest/wiki/Creating-my-first-test

If you take the time to write a clean commit message, merging for me is a one click process from the web interface. If you don't, I have to spend about 25 minutes on the command line editing and rewriting everything according to the Stockfish history style.

@Vizvezdenec
Copy link
Contributor Author

Vizvezdenec commented Aug 21, 2019

I open commits from work PC and it usually bugs out teamviewer saying I use it for "commercial purpose". So even this minor cleanup (like cleaning commits history and making a new commit and making PR for it) takes me like 35 minutes (since my repo is at home PC and I can do really few actions once / 10 minutes).
Writing long commit message will take me like forever (unless I'm doing it at home but then I wouldn't be able to open PR till evening).
I will try to do it for my next PRs if I have time for it.

@snicolet snicolet changed the title Always do LMR for captures at cutnodes. Late move reduction, captures and CUT nodes Aug 21, 2019
@snicolet snicolet closed this in 10d2ebc Aug 21, 2019
@snicolet
Copy link
Member

merged via 10d2ebc, thanks :)

MichaelB7 pushed a commit to MichaelB7/Stockfish that referenced this pull request Aug 23, 2019
Expand of Stefan Geschwentner's original idea: we always do LMR for captures at cutnodes.

Passed STC
http://tests.stockfishchess.org/tests/view/5d5b2f8e0ebc5925cf1111b8
LLR: 2.96 (-2.94,2.94) [0.50,4.50]
Total: 36026 W: 8122 L: 7779 D: 20125

Passed LTC
http://tests.stockfishchess.org/tests/view/5d5b40c80ebc5925cf111353
LLR: 3.22 (-2.94,2.94) [0.00,3.50]
Total: 133502 W: 22508 L: 21943 D: 89051

Closes official-stockfish#2273

Bench: 3494372
mstembera pushed a commit to mstembera/Stockfish that referenced this pull request Aug 29, 2019
Expand of Stefan Geschwentner's original idea: we always do LMR for captures at cutnodes.

Passed STC
http://tests.stockfishchess.org/tests/view/5d5b2f8e0ebc5925cf1111b8
LLR: 2.96 (-2.94,2.94) [0.50,4.50]
Total: 36026 W: 8122 L: 7779 D: 20125

Passed LTC
http://tests.stockfishchess.org/tests/view/5d5b40c80ebc5925cf111353
LLR: 3.22 (-2.94,2.94) [0.00,3.50]
Total: 133502 W: 22508 L: 21943 D: 89051

Closes official-stockfish#2273

Bench: 3494372
pb00068 pushed a commit to pb00068/Stockfish that referenced this pull request Sep 10, 2019
Expand of Stefan Geschwentner's original idea: we always do LMR for captures at cutnodes.

Passed STC
http://tests.stockfishchess.org/tests/view/5d5b2f8e0ebc5925cf1111b8
LLR: 2.96 (-2.94,2.94) [0.50,4.50]
Total: 36026 W: 8122 L: 7779 D: 20125

Passed LTC
http://tests.stockfishchess.org/tests/view/5d5b40c80ebc5925cf111353
LLR: 3.22 (-2.94,2.94) [0.00,3.50]
Total: 133502 W: 22508 L: 21943 D: 89051

Closes official-stockfish#2273

Bench: 3494372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants