From c103c8de475bc4b44a2ce974c968929a26b0927b Mon Sep 17 00:00:00 2001
From: ppigazzini <pasquale.pigazzini@gmail.com>
Date: Tue, 25 Jun 2024 13:28:21 +0200
Subject: [PATCH] Fix flake8 errors/warnings

---
 server/fishtest/api.py   |  1 -
 server/fishtest/rundb.py | 12 +-----------
 server/fishtest/views.py |  8 +++++---
 3 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/server/fishtest/api.py b/server/fishtest/api.py
index 6a36baf4d..1e3e8d0f4 100644
--- a/server/fishtest/api.py
+++ b/server/fishtest/api.py
@@ -296,7 +296,6 @@ def stop_run(self):
                 run["failed"] = True
                 self.request.rundb.stop_run(self.run_id())
             else:
-                task = self.task()
                 self.request.rundb.set_inactive_task(self.task_id(), run)
                 self.request.rundb.buffer(run, True)
 
diff --git a/server/fishtest/rundb.py b/server/fishtest/rundb.py
index 672e7cc31..a60ceef23 100644
--- a/server/fishtest/rundb.py
+++ b/server/fishtest/rundb.py
@@ -7,7 +7,7 @@
 import textwrap
 import threading
 import time
-from datetime import datetime, timedelta, timezone
+from datetime import datetime, timezone
 
 import fishtest.stats.stat_util
 from bson.binary import Binary
@@ -34,7 +34,6 @@
     Scheduler,
     crash_or_time,
     estimate_game_duration,
-    format_bounds,
     format_results,
     get_bad_workers,
     get_chi2,
@@ -681,7 +680,6 @@ def flush_buffers(self):
         old = float("inf")
         with self.run_cache_lock:
             for cache_entry in self.run_cache.values():
-                run = cache_entry["run"]
                 if cache_entry["is_changed"] and cache_entry["last_sync_time"] < old:
                     old = cache_entry["last_sync_time"]
                     oldest_entry = cache_entry
@@ -1540,14 +1538,6 @@ def purge_run(self, run, p=0.001, res=7.0, iters=1):
             run["bad_tasks"] = []
 
         tasks = copy.copy(run["tasks"])
-        zero_stats = {
-            "wins": 0,
-            "losses": 0,
-            "draws": 0,
-            "crashes": 0,
-            "time_losses": 0,
-            "pentanomial": 5 * [0],
-        }
 
         for task_id, task in enumerate(tasks):
             if "bad" in task:
diff --git a/server/fishtest/views.py b/server/fishtest/views.py
index efe15645a..8e5538404 100644
--- a/server/fishtest/views.py
+++ b/server/fishtest/views.py
@@ -11,7 +11,7 @@
 
 import fishtest.stats.stat_util
 import requests
-from fishtest.schemas import runs_schema, short_worker_name
+from fishtest.schemas import RUN_VERSION, runs_schema, short_worker_name
 from fishtest.util import (
     email_valid,
     extract_repo_from_link,
@@ -1404,10 +1404,12 @@ def tests_delete(request):
         try:
             validate(runs_schema, run, "run")
         except ValidationError as e:
-            message = f"The run object {run_id} does not validate: {str(e)}"
+            message = (
+                f"The run object {request.POST["run-id"]} does not validate: {str(e)}"
+            )
             print(message, flush=True)
             if "version" in run and run["version"] >= RUN_VERSION:
-                self.actiondb.log_message(
+                request.actiondb.log_message(
                     username="fishtest.system",
                     message=message,
                 )