Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override _result #633

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@mydea
Copy link
Contributor

mydea commented Apr 12, 2019

Overwriting _result triggers a deprecation warning in newer versions of Ember.
This PR fixes this by instead writing another overwrite-property, which is used by _result instead (if set).

@mydea mydea force-pushed the mydea:fno/dont-overwrite-cps branch from 9581a50 to 151693d Apr 12, 2019

Do not override _result
This triggers a deprecation warning in newer Ember versions.

@mydea mydea force-pushed the mydea:fno/dont-overwrite-cps branch from 151693d to 8da446c Apr 12, 2019

@mydea

This comment has been minimized.

Copy link
Contributor Author

mydea commented Apr 12, 2019

The failing tests are unrelated to this change, I believe.

@offirgolan offirgolan self-requested a review Apr 12, 2019

@offirgolan offirgolan merged commit 3f8423f into offirgolan:master Apr 12, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.